-
-
Notifications
You must be signed in to change notification settings - Fork 650
Open
Description
π bug report
Affected Rule
py_test/py_library (and Gazelle, not a rule)
Is this a regression?
I'd argue so π. #2998 introduced the new behavior (released in 1.6.0).
(more details in description)
Description
(Before I begin, please note I like #2998 as a change. I just don't like a seemingly breaking change without any warning or toggles or migration path).
I'm upgrading my work monorepo rules_python to the latest, version-by-version. 1.6.0 has apparently become a very hard stop on my journey, due to incompatible gazelle changes. At a high level this is because:
- After upgrade,
gazelleis happy to add new targets, while leaving the old targets alone - There's no way to emulate the old behavior. The closest is trying different
# gazelle:python_generation_modes to see what gives me a small (enough) diff - There's no way to incrementally roll this out (e.g. the result is one mega-PR)
- Whereas the old way made it so you could cleverly solve import cycles (across multiple subdirs) the new way makes that challenging
- conftest inclusion is a bit broken
π¬ Minimal Reproduction
(I'll try and work on a demo repo showing each of the bullet points above, bear with me)
π₯ Exception or Error
(N/A)
π Your Environment
(N/A)
Metadata
Metadata
Assignees
Labels
No labels