chore: load specific bzl files instead of generic defs.bzl #2483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickeylev
force-pushed
the
chore.rm.defs.usages
branch
from
91737c4 to
5753f1a
Compare
aignas
approved these changes
Dec 7, 2024
Collaborator
aignas
left a comment
aignas
left a comment
There was a problem hiding this comment.
Should we make the defs.bzl deprecated? We could add a deprecation notice that they will be removed in the upcoming major version of rules_python?
Collaborator
Author
|
I'd be fine with "soft" deprecating it. It's been around for a long time and there's quite a few usages of it out there. Re-exporting the symbols is very low maintenance, so I don't want to remove it without a long period. |
ewianda
pushed a commit
to ewianda/rules_python
that referenced
this pull request
Dec 7, 2024
…trib#2483) Update code and examples to load the object-specific bzl files instead of the generic `defs.bzl`. This is mostly for code hygiene, but came out of trying to diagnose why Bazel 9 workspace builds kept erroing with defs.bzl somehow related. Removing the internal usages of defs.bzl doesn't seem to fully fix it, but does seem to eliminate some errors, make some progress, and narrow down what's going on. Work towards bazel-contrib#2469
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update code and examples to load the object-specific bzl files instead of the
generic
defs.bzl. This is mostly for code hygiene, but came out of trying to diagnosewhy Bazel 9 workspace builds kept erroing with defs.bzl somehow related. Removing
the internal usages of defs.bzl doesn't seem to fully fix it, but does seem to eliminate
some errors, make some progress, and narrow down what's going on.
Work towards #2469