Skip to content

Conversation

@rickeylev
Copy link
Collaborator

@rickeylev rickeylev commented Dec 12, 2024

Building with Bazel 9 using WORKSPACE results in an odd error that PyInfo
isn't defined. Oddly, the error refers to rules_python/python/private/reexports.bzl
for rules_python 0.28.0. This seems to only happen when the main module is rules_python.

While Bazel 9 is supposed to drop workspace support, I've been advised it's better to
keep testing WORKSPACE support until closer to when Bazel 9 fully removes it.

My best guess about what's happening is Bazel's autoloading is triggering and somehow
defining rules_python before it's recognized that the main module is rules_python.
The autoloading appears to be triggered, eventually, by things in bazel_tools loading
rules_python.

While removing unnecessary @bazel_tools loads in rules_python helps, the particular
case I can't find a clean solution to is when
@@rules_java//toolchains:toolchain_java11_definition causes rules_python to be
loaded. This appears to end up loading rules_python via
@bazel_tools//tools/jdk:BUILD, which has has some py rules defined in it.

To fix/work around this issue, local_repository can be used to define the rules_python
repo before autoloading happens. This appears to take precedence over whatever logic
autoloading has.

Work towards #2469

@rickeylev rickeylev requested a review from aignas as a code owner December 12, 2024 17:57
@rickeylev rickeylev added this pull request to the merge queue Dec 13, 2024
Merged via the queue into bazel-contrib:main with commit 94c77e2 Dec 13, 2024
4 checks passed
@rickeylev rickeylev deleted the fix.bazel9 branch December 13, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants