From 7d785f9d037fe4e78d14a43adc0446596992f10b Mon Sep 17 00:00:00 2001 From: Keith Smiley Date: Fri, 28 Feb 2025 18:24:29 +0000 Subject: [PATCH] Add error for pip.parse attrs that require other attrs This makes it more clear when you've misconfigured pip.parse --- python/private/pypi/extension.bzl | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/python/private/pypi/extension.bzl b/python/private/pypi/extension.bzl index 405c22f60e..1a7d1e12ea 100644 --- a/python/private/pypi/extension.bzl +++ b/python/private/pypi/extension.bzl @@ -481,6 +481,10 @@ You cannot use both the additive_build_content and additive_build_content_file a cache = simpleapi_cache, parallel_download = pip_attr.parallel_download, ) + elif pip_attr.experimental_extra_index_urls: + fail("'experimental_extra_index_urls' is a no-op unless 'experimental_index_url' is set") + elif pip_attr.experimental_index_url_overrides: + fail("'experimental_index_url_overrides' is a no-op unless 'experimental_index_url' is set") out = _create_whl_repos( module_ctx,