fix(pypi): call python --version before marker eval #2819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`bzlmod` has the full python version information statically and we don't need to call Python to get its version, but for `WORKSPACE` that is not the case and we have to call it before evaluating the markers in universal requirements files. Fixes bazel-contrib#2818
vonschultz
reviewed
Apr 24, 2025
| @@ -1,10 +1,10 @@ | |||
| # | |||
| # This file is autogenerated by pip-compile with Python 3.10 | |||
| # This file is autogenerated by pip-compile with Python 3.9 | |||
There was a problem hiding this comment.
I think this file should be generated with Python 3.10.
There was a problem hiding this comment.
Done, it seems that the transition had a bug, so this PR will fix 2 bugs at once :D
examples/multi_python_versions/requirements/requirements_lock_3_11.txt
Outdated
Show resolved
Hide resolved
rickeylev
approved these changes
Apr 24, 2025
rickeylev
pushed a commit
that referenced
this pull request
Apr 24, 2025
`bzlmod` has the full python version information statically and we don't need to call Python to get its version, but for `WORKSPACE` that is not the case and we have to call it before evaluating the markers in universal requirements files. This also fixes transitions in the `compile_pip_requirements` macro where the `.update` target would not transition correctly based on the `python_version` parameter. Fixes #2818 (cherry picked from commit ee34409)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bzlmodhas the full python version information statically and we don'tneed to call Python to get its version, but for
WORKSPACEthat is notthe case and we have to call it before evaluating the markers in
universal requirements files.
This also fixes transitions in the
compile_pip_requirementsmacro wherethe
.updatetarget would not transition correctly based on thepython_versionparameter.Fixes #2818