Skip to content

Conversation

@jacky8hyf
Copy link
Contributor

With bootstrap_impl=system_python, after
#2607, host Python 3.6 and above is required because of the use of multiline f-strings. For maximum backwards compatibility (because this is a host dependency), do not use multiline f-strings.

This issue naturally does not apply to bootstrap_impl=script because there are no host Python dependency.

Link: #2607

With bootstrap_impl=system_python, after
bazel-contrib#2607,
host Python 3.6 and above is required because of the use of multiline
f-strings. For maximum backwards compatibility (because this is a host
dependency), do not use multiline f-strings.

This issue naturally does not apply to bootstrap_impl=script because
there are no host Python dependency.

Link: bazel-contrib#2607
Copy link
Collaborator

@rickeylev rickeylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

This is a simple change, so LGTM.

Note that there's no guarantees future changes won't introduce incompatibility with old python versions. We won't actively guard against that, but PRs to fix it will likely accepted.

@rickeylev rickeylev added this pull request to the merge queue Aug 13, 2025
Merged via the queue into bazel-contrib:main with commit 2eacb70 Aug 13, 2025
2 checks passed
@jacky8hyf jacky8hyf deleted the py36fix branch August 14, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants