refactor(pypi): split out a hub_builder helper from the extension code #3243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickeylev
approved these changes
Sep 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a somewhat tedious refactor, where I am just moving code around
(and sometimes renaming various parameters).
I am not modifying and/or fixing any bugs other than more error messages
in one place since I noticed there was a lack of validation. The main
idea is to create a
hub_builderso that we could also use it forpip.configurecalls and/or use it forpy.lockfile parsing and reusecode. I hope that moving it to a separate file makes it a little bit
more obvious what pieces are used to create a hub repository.
What is more, since the pip extension is reproducible, I have removed
some code that was sorting the output.
Work towards #2747