tests: add tests to verify toolchain registration #3313
Conversation
Summary of ChangesHello @rickeylev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the testing infrastructure by adding new tests focused on the correct registration and resolution of Python toolchains under diverse build configurations. It also includes a refactoring of how platform targets are defined and referenced within the test suite, consolidating them into a dedicated Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive test suite to verify Python toolchain registration and resolution across different platforms and configurations. It also refactors platform definitions for better maintainability. The changes are generally good, but I've identified a couple of areas for improvement: one for code simplification and another to fix a potential issue in the new tests.
tests/toolchains/multi_platform_resolution/resolution_tests.bzl
Outdated
Show resolved
Hide resolved
This adds tests that verify toolchains are registered and resolving correctly for
the different variants and platforms for the runtimes.
This also shows that workspace mode isn't registering musl or freethreaded builds
correctly, so use them isn't as easy as simply setting the build flags. For now,
the tests skip those in workspace mode.
Along the way, fix a bug where py_runtime would crash if it got the python version
from the flag, and the version contained more than micro (e.g. "3.14.0rc0")