Skip to content

feat: Add libpython QNX platform support #3372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 26, 2025
Merged

feat: Add libpython QNX platform support #3372

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
260945d
Add libpython QNX platform support
lalten Oct 20, 2025
18c5832
Merge branch 'main' into patch-1
aignas Oct 21, 2025
d8f462a
//confitions:default
lalten Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions python/private/hermetic_runtime_repo_setup.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,10 @@ def define_hermetic_runtime_toolchain_impl(
"lib/libpython{major}.{minor}.so.1.0".format(**version_dict),
],
"@platforms//os:macos": ["lib/libpython{major}.{minor}.dylib".format(**version_dict)],
"@platforms//os:qnx": [
Copy link
Collaborator

@aignas aignas Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please refactor the code so that this is the default? It seems that linux and qnx have the same code here, so in theory we could just default to that. I wonder if that would incidentally also help FreeBSD, which we don't support, but you never know what PR will come in the future.

@rickeylev, what would you think about this?

Copy link
Contributor Author

@lalten lalten Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, I think that's a good idea

"lib/libpython{major}.{minor}.so".format(**version_dict),
"lib/libpython{major}.{minor}.so.1.0".format(**version_dict),
],
"@platforms//os:windows": [
"python3.dll",
"python{major}{minor}.dll".format(**version_dict),
Expand Down