Skip to content

revert(pypi): revert the default for pipstar #3373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 24, 2025
Merged

revert(pypi): revert the default for pipstar #3373

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff9df6b
revert(pypi): revert the default for pipstar
aignas Oct 21, 2025
2c86fdf
Apply suggestion from @aignas
aignas Oct 21, 2025
0426b49
Merge branch 'main' into aignas.revert.pipstar-flag
aignas Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,10 @@ END_UNRELEASED_TEMPLATE
* (toolchains) `py_runtime` and `PyRuntimeInfo` reject Python 2 settings.
Setting `py_runtime.python_version = "PY2"` or non-None
`PyRuntimeInfo.py2_runtime` is an error.
* (pypi) `pipstar` flag has been flipped to be enabled by default, to turn it
off use `RULES_PYTHON_ENABLE_PIPSTAR=0` environment variable. If you do, please
* (pypi) `pipstar` flag has been implemented for `WORKSPACE` and can be flipped to be enabled using `RULES_PYTHON_ENABLE_PIPSTAR=0` environment variable. If you do, please
add a comment to
[#2949](https://github.com/bazel-contrib/rules_python/issues/2949).
[#2949](https://github.com/bazel-contrib/rules_python/issues/2949) if you run into any
problems.
With this release we are deprecating {obj}`pip.parse.experimental_target_platforms` and
{obj}`pip_repository.experimental_target_platforms`. For users using `WORKSPACE` and
vendoring the `requirements.bzl` file, please re-vendor so that downstream is unaffected
Expand Down
2 changes: 1 addition & 1 deletion python/private/internal_config_repo.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ load("//python/private:text_util.bzl", "render")
load(":repo_utils.bzl", "repo_utils")

_ENABLE_PIPSTAR_ENVVAR_NAME = "RULES_PYTHON_ENABLE_PIPSTAR"
_ENABLE_PIPSTAR_DEFAULT = "1"
_ENABLE_PIPSTAR_DEFAULT = "0"
_ENABLE_DEPRECATION_WARNINGS_ENVVAR_NAME = "RULES_PYTHON_DEPRECATION_WARNINGS"
_ENABLE_DEPRECATION_WARNINGS_DEFAULT = "0"

Expand Down