Skip to content

Commit 4e9ea4d

Browse files
authored
fix: runfiles merging for @bazel_tools//tools/bash/runfiles (#234)
This is required in Bazel 8.3.0, where this target gained runfiles.
1 parent cc08811 commit 4e9ea4d

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

ruby/private/binary.bzl

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ Supports `$(location)` expansion for targets from `srcs`, `data` and `deps`.
5656
default = "@rules_ruby//ruby/private/binary:binary.sh.tpl",
5757
),
5858
"_runfiles_library": attr.label(
59-
allow_single_file = True,
6059
default = "@bazel_tools//tools/bash/runfiles",
6160
),
6261
"_windows_constraint": attr.label(
@@ -141,8 +140,7 @@ def rb_binary_impl(ctx):
141140
ruby_toolchain = ctx.toolchains["@rules_ruby//ruby:toolchain_type"]
142141
if ctx.attr.ruby != None:
143142
ruby_toolchain = ctx.attr.ruby[platform_common.ToolchainInfo]
144-
tools = [ctx.file._runfiles_library]
145-
tools.extend(ruby_toolchain.files)
143+
tools = list(ruby_toolchain.files)
146144

147145
if ruby_toolchain.version.startswith("jruby"):
148146
java_toolchain = ctx.toolchains["@bazel_tools//tools/jdk:runtime_toolchain_type"]
@@ -174,6 +172,7 @@ def rb_binary_impl(ctx):
174172

175173
runfiles = ctx.runfiles(tools, transitive_files = depset(transitive = [transitive_srcs, transitive_data]))
176174
runfiles = get_transitive_runfiles(runfiles, ctx.attr.srcs, ctx.attr.deps, ctx.attr.data)
175+
runfiles = runfiles.merge(ctx.attr._runfiles_library[DefaultInfo].default_runfiles)
177176

178177
# Propagate executable from source rb_binary() targets.
179178
executable = ctx.executable.main

ruby/private/gem_push.bzl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ def _rb_gem_push_impl(ctx):
1010
if ctx.attr.ruby != None:
1111
ruby_toolchain = ctx.attr.ruby[platform_common.ToolchainInfo]
1212
srcs = [ctx.file.gem]
13-
tools = [ruby_toolchain.gem, ctx.file._runfiles_library]
13+
tools = [ruby_toolchain.gem]
1414

1515
if ruby_toolchain.version.startswith("jruby"):
1616
env["JAVA_HOME"] = java_toolchain.java_runtime.java_home
@@ -24,6 +24,7 @@ def _rb_gem_push_impl(ctx):
2424
)
2525

2626
runfiles = ctx.runfiles(srcs + tools)
27+
runfiles = runfiles.merge(ctx.attr._runfiles_library[DefaultInfo].default_runfiles)
2728
env.update(ctx.attr.env)
2829

2930
return [

0 commit comments

Comments
 (0)