Revert "Declare non-windows executable with .sh extension (#1407)" (#1446)

This reverts commit 71d7135.

Author: ittaiz

docs/scala_repl.md

@@ -21,5 +21,5 @@ Instead, use `bazel build` to build the script, then run that script as normal t
 An example in this repo:
 ```
 bazel build test:HelloLibRepl
-bazel-bin/test/HelloLibRepl.sh
+bazel-bin/test/HelloLibRepl
 ```

scala/private/phases/phase_declare_executable.bzl

@@ -15,5 +15,5 @@ def phase_declare_executable(ctx, p):
         )
     else:
         return struct(
-            executable = ctx.actions.declare_file("%s.sh" % ctx.label.name),
+            executable = ctx.actions.declare_file(ctx.label.name),
         )

test/BUILD

@@ -472,7 +472,6 @@ scala_specs2_junit_test(
     "//test/src/main/scala/scalarules/test/large_classpath:largeClasspath",
     "//test:test_scala_proto_server",
     "//test:scala_binary_jdk_11",
-    "//test/artifact_prefix_conflict_example/example:example",
 ]]
 
 # Make sure scala_binary respects runtime_jdk on bazel run

test/artifact_prefix_conflict_example/example/ArtifactPrefixConflictExample.scala

@@ -3,9 +3,9 @@
 set -eou pipefail
 
 content="$(cat $1)"
-expected=$'test/ScalaBinary.jar\ntest/ScalaBinary.sh'
+expected=$'test/ScalaBinary\ntest/ScalaBinary.jar'
 if [ "$content" != "$expected" ]; then
     echo "Unexpected rootpaths: $content"
-    echo "Expected rootpaths: $expected"
+    echo "$expected"
     exit 1
 fi

test/artifact_prefix_conflict_example/example/BUILD

@@ -51,11 +51,11 @@ test_transitive_deps() {
 
 test_repl() {
   bazel build $(bazel query 'kind(scala_repl, //test/...)')
-  echo "import scalarules.test._; HelloLib.printMessage(\"foo\")" | bazel-bin/test/HelloLibRepl.sh -Xnojline | grep "foo java" &&
-  echo "import scalarules.test._; TestUtil.foo" | bazel-bin/test/HelloLibTestRepl.sh -Xnojline | grep "bar" &&
-  echo "import scalarules.test._; ScalaLibBinary.main(Array())" | bazel-bin/test/ScalaLibBinaryRepl.sh -Xnojline | grep "A hui hou" &&
-  echo "import scalarules.test._; ResourcesStripScalaBinary.main(Array())" | bazel-bin/test/ResourcesStripScalaBinaryRepl.sh -Xnojline | grep "More Hello"
-  echo "import scalarules.test._; A.main(Array())" | bazel-bin/test/ReplWithSources.sh -Xnojline | grep "4 8 15"
+  echo "import scalarules.test._; HelloLib.printMessage(\"foo\")" | bazel-bin/test/HelloLibRepl -Xnojline | grep "foo java" &&
+  echo "import scalarules.test._; TestUtil.foo" | bazel-bin/test/HelloLibTestRepl -Xnojline | grep "bar" &&
+  echo "import scalarules.test._; ScalaLibBinary.main(Array())" | bazel-bin/test/ScalaLibBinaryRepl -Xnojline | grep "A hui hou" &&
+  echo "import scalarules.test._; ResourcesStripScalaBinary.main(Array())" | bazel-bin/test/ResourcesStripScalaBinaryRepl -Xnojline | grep "More Hello"
+  echo "import scalarules.test._; A.main(Array())" | bazel-bin/test/ReplWithSources -Xnojline | grep "4 8 15"
 }
 
 test_benchmark_jmh() {