From 4745670b456df587b3beea352e277091e707192c Mon Sep 17 00:00:00 2001 From: jeremyrsmith Date: Wed, 17 Sep 2025 15:42:55 -0700 Subject: [PATCH 1/2] Pass `jvm_flags` through `scala_benchmark_jmh` This is necessary, for example, when a benchmark depends on some library that needs `--add-opens`. --- jmh/jmh.bzl | 2 ++ 1 file changed, 2 insertions(+) diff --git a/jmh/jmh.bzl b/jmh/jmh.bzl index a34bd4aea..522352fdb 100644 --- a/jmh/jmh.bzl +++ b/jmh/jmh.bzl @@ -67,6 +67,7 @@ def scala_benchmark_jmh(**kw): testonly = kw.get("testonly", False) scalacopts = kw.get("scalacopts", []) main_class = kw.get("main_class", "org.openjdk.jmh.Main") + jvm_flags = kw.get("jvm_flags", []) runtime_jdk = kw.get( "runtime_jdk", "@rules_java//toolchains:current_java_runtime", @@ -116,4 +117,5 @@ def scala_benchmark_jmh(**kw): testonly = testonly, unused_dependency_checker_mode = "off", runtime_jdk = runtime_jdk, + jvm_flags = jvm_flags ) From 0a098c9dd5dd9ae4021dba63eb4422102c320644 Mon Sep 17 00:00:00 2001 From: jeremyrsmith Date: Wed, 17 Sep 2025 15:44:40 -0700 Subject: [PATCH 2/2] Re-add trailing comma --- jmh/jmh.bzl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jmh/jmh.bzl b/jmh/jmh.bzl index 522352fdb..0d78c76ea 100644 --- a/jmh/jmh.bzl +++ b/jmh/jmh.bzl @@ -117,5 +117,5 @@ def scala_benchmark_jmh(**kw): testonly = testonly, unused_dependency_checker_mode = "off", runtime_jdk = runtime_jdk, - jvm_flags = jvm_flags + jvm_flags = jvm_flags, )