Improve diagnostics

Author: calebzulawski

gc.js

@@ -4,17 +4,14 @@ const path = require('path')
 const core = require('@actions/core')
 
 function init(cacheConfig) {
-  if (!cacheConfig.enabled) {
-    return
-  }
-
   core.startGroup(`Computing initial ${cacheConfig.name} cache hash`)
   fs.writeFileSync(cacheConfig.path + '.sha256', computeCacheHash(cacheConfig.path))
   core.endGroup()
 }
 
 function run(cacheConfig) {
   if (!fs.existsSync(cacheConfig.path)) {
+    core.warning(`No ${cacheConfig.name} cache present`)
     return
   }
 

index.js

@@ -142,10 +142,6 @@ async function restoreExternalCaches(cacheConfig) {
 }
 
 async function restoreCacheImpl(cacheConfig, primaryKey, restoreKeys, cacheHit) {
-  if (!cacheConfig.enabled) {
-    return
-  }
-
   const delay = Math.random() * 1000 // timeout <= 1 sec to reduce 429 errors
   await setTimeout(delay, async function () {
     core.startGroup(`Restore cache for ${cacheConfig.name}`)
@@ -175,6 +171,10 @@ async function restoreCacheImpl(cacheConfig, primaryKey, restoreKeys, cacheHit)
 }
 
 async function restoreCache(cacheConfig) {
+  if (!cacheConfig.enabled) {
+    return
+  }
+
   const hash = await glob.hashFiles(cacheConfig.files.join('\n'))
   const restoreKey = `${config.baseCacheKey}-${cacheConfig.name}-`
   const key = `${restoreKey}${hash}`
@@ -185,6 +185,10 @@ async function restoreCache(cacheConfig) {
 }
 
 async function restoreGcCache(cacheConfig) {
+  if (!cacheConfig.enabled) {
+    return
+  }
+
   // Since disk caches get updated on any change, each run has a unique key.
   // Therefore it can only be restored by prefix match, rather than exact key match.
   // When multiple prefix matches exist, the most recent is selected.

post.js

@@ -68,17 +68,18 @@ async function saveGcCache(cacheConfig) {
 
   const hash = gc.run(cacheConfig)
 
+  core.startGroup(`Save cache for ${cacheConfig.name}`)
+
   // cache is unchanged
   if (!hash) {
+    core.info(`No changes to ${cacheConfig} cache detected, skipping upload`)
     return
   }
 
   const key = `${config.baseCacheKey}-${cacheConfig.name}-${hash}`
   const paths = cacheConfig.paths
 
   try {
-    core.startGroup(`Save cache for ${cacheConfig.name}`)
-
     // cache already exists
     if (await cache.restoreCache(paths, key, [], { lookupOnly: true })) {
       core.info('Cache already exists, skipping upload')
@@ -90,9 +91,9 @@ async function saveGcCache(cacheConfig) {
     core.info('Successfully saved cache')
   } catch (error) {
     core.warning(error.stack)
-  } finally {
-    core.endGroup()
   }
+
+  core.endGroup()
 }
 
 async function saveCache(cacheConfig) {