Improve GC logic when large files are present

calebzulawski · calebzulawski · commit 5afe4e28f3b0 · 2025-03-12T13:12:09.000-04:00
diff --git a/gc.js b/gc.js
@@ -32,10 +32,11 @@ function run(cacheConfig) {
   let cacheSize = 0
   let reclaimed = 0
   for (const { file, size } of files) {
-    cacheSize += size
-    if (cacheSize >= deleteThreshold) {
+    if (cacheSize + size >= deleteThreshold) {
       fs.unlinkSync(file)
       reclaimed++
+    } else {
+      cacheSize += size
     }
   }
   core.info(`Reclaimed ${reclaimed} files`)

Original file line number	Diff line number	Diff line change
`@@ -32,10 +32,11 @@ function run(cacheConfig) {`
`32`	`32`	`let cacheSize = 0`
`33`	`33`	`let reclaimed = 0`
`34`	`34`	`for (const { file, size } of files) {`
`35`		`- cacheSize += size`
`36`		`- if (cacheSize >= deleteThreshold) {`
	`35`	`+ if (cacheSize + size >= deleteThreshold) {`
`37`	`36`	`fs.unlinkSync(file)`
`38`	`37`	`reclaimed++`
	`38`	`+ } else {`
	`39`	`+ cacheSize += size`
`39`	`40`	`}`
`40`	`41`	`}`
`41`	`42`	core.info(`Reclaimed ${reclaimed} files`)