Skip to content

Commit 1925ad1

Browse files
authored
Switch from OpenSSL to BoringSSL for tests (#596)
We should not test whether a specific variant of getting SSL works. Instead we can verify that one well supported one works.
1 parent 91996f2 commit 1925ad1

File tree

10 files changed

+9
-1176
lines changed

10 files changed

+9
-1176
lines changed

.github/workflows/tests.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,7 @@ jobs:
6161
strategy:
6262
fail-fast: false
6363
matrix:
64-
# TODO: This doesn't work with arm64 Macs yet. That is due to openssl being x86 only here.
65-
# Since macos-14+ requires "-large" we have to disable this for now.
66-
os: [ubuntu-latest]
64+
os: [macos-latest, ubuntu-latest]
6765
bazel_version: [latest] # rules_rust bzlmod support is experimental and needs latest version as of now (20230912).
6866
bzlmod: [true, false]
6967
runs-on: ${{ matrix.os }}

tests/MODULE.bazel

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,13 @@ local_path_override(
2323
bazel_dep(name = "bazel_skylib", version = "1.8.2")
2424
bazel_dep(name = "platforms", version = "1.0.0")
2525
bazel_dep(name = "rules_cc", version = "0.2.8")
26+
bazel_dep(name = "rules_foreign_cc", version = "0.15.0")
2627
bazel_dep(name = "rules_go", version = "0.50.1", repo_name = "io_bazel_rules_go")
28+
bazel_dep(name = "rules_license", version = "1.0.0")
2729
bazel_dep(name = "rules_rust", version = "0.67.0")
28-
bazel_dep(name = "rules_foreign_cc", version = "0.15.0")
2930
bazel_dep(name = "rules_shell", version = "0.6.1")
3031
bazel_dep(name = "abseil-cpp", version = "20250814.1", repo_name = "com_google_absl")
32+
bazel_dep(name = "boringssl", version = "0.20251002.0")
3133

3234
# TODO: Remove when protobuf is released with a version of rules_python that supports 8.x
3335
bazel_dep(name = "rules_python", version = "1.6.3")

tests/WORKSPACE

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -267,11 +267,10 @@ http_archive(
267267
)
268268

269269
http_archive(
270-
name = "openssl",
271-
build_file = "//openssl:openssl.bazel",
272-
sha256 = "f6fb3079ad15076154eda9413fed42877d668e7069d9b87396d0804fdb3f4c90",
273-
strip_prefix = "openssl-1.1.1c",
274-
urls = ["https://www.openssl.org/source/openssl-1.1.1c.tar.gz"],
270+
name = "boringssl",
271+
sha256 = "f96733fc3df03d4195db656d1b7b8c174c33f95d052f811f0ecc8f4e4e3db332",
272+
strip_prefix = "boringssl-0.20251002.0",
273+
urls = ["https://github.com/google/boringssl/releases/download/0.20251002.0/boringssl-0.20251002.0.tar.gz"],
275274
)
276275

277276
http_archive(

tests/WORKSPACE.bzlmod

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,6 @@ load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
44

55
# Well known repos; present here only for testing.
66

7-
http_archive(
8-
name = "openssl",
9-
build_file = "//openssl:openssl.bazel",
10-
sha256 = "f6fb3079ad15076154eda9413fed42877d668e7069d9b87396d0804fdb3f4c90",
11-
strip_prefix = "openssl-1.1.1c",
12-
urls = ["https://www.openssl.org/source/openssl-1.1.1c.tar.gz"],
13-
)
14-
157
_ALL_CONTENT = """\
168
filegroup(
179
name = "all_srcs",

tests/openssl/BUILD.bazel

Lines changed: 0 additions & 4 deletions
This file was deleted.

tests/openssl/crypto/include/internal/bn_conf.h

Lines changed: 0 additions & 28 deletions
This file was deleted.

tests/openssl/crypto/include/internal/dso_conf.h

Lines changed: 0 additions & 17 deletions
This file was deleted.

tests/openssl/include/openssl/opensslconf.h

Lines changed: 0 additions & 191 deletions
This file was deleted.

0 commit comments

Comments
 (0)