Skip to content

Various updates #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Various updates #585

wants to merge 4 commits into from
+848 −1,173

Conversation

@helly25
Copy link
Collaborator

@helly25 helly25 commented Oct 26, 2025

  • MacOS to latest
  • OpenSSL to latest (1.1.1 is outdated and has only special support)
  • Abseil
  • Missing LLVM version requirement handling

@helly25
Various updates
e791131 
* MacOS to latest
* OpenSSL to latest (1.1.1 is outdated and has only special support)
* Abseil
* Missing LLVM version requirement handling
@helly25 helly25 requested a review from dzbarsky as a code owner November 1, 2025 12:32
dzbarsky
dzbarsky approved these changes Nov 1, 2025
View reviewed changes
Copy link
Collaborator

@dzbarsky dzbarsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we maybe just drop openssl from workspace? It's a lot of boilerplate to carry around for lack of BCR module

@helly25
Copy link
Collaborator Author

helly25 commented Nov 1, 2025

Should we maybe just drop openssl from workspace? It's a lot of boilerplate to carry around for lack of BCR module

There actually is OpenSSL support. It's called https://boringssl.googlesource.com/boringssl which has BCR support in "boringssl". We could maybe go to that after this? Unless of course I cannot get this version working. The reason to try this current approach is to have a cleaner SSL rather than the strange boringssl variant. Though I assume that with BCR support Google finally fixed the strangeness (It was re-generated on download... don't ask).

@helly25 helly25 closed this Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dzbarsky dzbarsky dzbarsky approved these changes

@fmeum fmeum fmeum approved these changes

@rrbutani rrbutani Awaiting requested review from rrbutani rrbutani is a code owner

@jsharpe jsharpe Awaiting requested review from jsharpe jsharpe is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@helly25 @dzbarsky @fmeum