Update llvm version used for tests. #586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow attribute llvm_versions to accept version requirements.
Allow attribute llvm_versions to specify version requirements.
fmeum
approved these changes
Oct 26, 2025
…nlike mine) we end up getting quotes.
… So we force version 15 for that. Possibly have to do so for some other tests as well.
Collaborator
Author
|
@fmeum Please take another look. |
fmeum
reviewed
Oct 31, 2025
Check whether all targets support omp again. If that fails we have to add some flags and other tag managment and determine why that is necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow attribute llvm_versions to specify version requirements.
Update some (main and test) dependencies.
Mark omp targets as manual (likely to be normal in a follow up).
Allow llvm_version to be taken from environment (or bazel command line). This does for newer bazel versions respect hermeticity.
Simplify version handling and log the resolution only in one place.
Update default llvm target version to "latest:>=17.0.0,<20" (e.g. 19) but allow environment overrides.