You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
2 Open questions:
1. Coming from [this
comment](#3453 (comment)):
Is there an automated validation check from the versioning pattern?
2. Is there a version pattern for projects that have not a single tagged
release? Should I use the date pattern here?
Copy file name to clipboardExpand all lines: docs/README.md
+4-4Lines changed: 4 additions & 4 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -17,7 +17,7 @@ The script will generate all require changes based on your input, please review,
17
17
If you are the project owner, you can set up the [Publish to BCR](https://github.com/apps/publish-to-bcr) Github App for your repository to automatically send a PR to the BCR when cutting a new release.
18
18
19
19
When manually editing files you may find `bazel run -- //tools:update_integrity foomod` useful to update the integrity hashes in foomod's source.json file.
20
-
The tool also accepts a `--version` option to update the source.json of a specific version of the module (instead of latest).
20
+
The tool also accepts a `--version` option to update the `source.json` of a specific version of the module (instead of latest).
21
21
22
22
### Testing your change locally
23
23
@@ -47,14 +47,14 @@ Validations performed in the scripts are:
47
47
48
48
- Verify the module version exists in the `metadata.json` of the module.
49
49
- Verify the source archive URL matches the source repository specified in `metadata.json`.
50
-
- Verify the source archive URL is stable if it comes from GitHub. (See [this discussion](https://github.com/bazel-contrib/SIG-rules-authors/issues/11#issuecomment-1029861300))
50
+
- Verify the source archive URL is stable if it comes from GitHub. (See [this discussion](https://github.com/bazel-contrib/SIG-rules-authors/issues/11#issuecomment-1029861300)). Comment `@bazel-io skip_check unstable_url` to skip this check.
51
51
- Verify the integrity values of the source archive and patch files (if any) are correct.
52
-
- Verify the checked-in MODULE.bazel file matches the one in the extracted and patched source tree.
52
+
- Verify the checked-in `MODULE.bazel` file matches the one in the extracted and patched source tree.
53
53
- Check if the module is new or the `presubmit.yml` file is changed compared to the last version, if so a BCR maintainer review will be required to run jobs specified in `presubmit.yml`.
54
54
55
55
Additional validations implemented in the [bcr_presubmit.py](https://github.com/bazelbuild/continuous-integration/blob/master/buildkite/bazel-central-registry/bcr_presubmit.py) script:
56
56
57
-
- The checked-in MODULE.bazel, source.json, patches files are not modified in the PR.
57
+
- The checked-in `MODULE.bazel`, `source.json`, patches files are not modified in the PR.
58
58
- The files outside of `modules/` directory are not modified in the pull request if the PR is adding a new module version.
0 commit comments