-
Notifications
You must be signed in to change notification settings - Fork 724
[Bug]: Incorrect pipeline comparison in module validation #7832
Copy link
Copy link
Open
Labels
bugSomething isn't workingSomething isn't working
Description
What happened?
I opened #7830 and it required a BCR maintainer review per:
Validating libgit2@1.7.2.bcr.1
BcrValidationResult.GOOD: The module exists and is recorded in metadata.json.
BcrValidationResult.GOOD: The source URL matches one of the source repositories.
BcrValidationResult.GOOD: The source archive's integrity value matches all provided URLs.
BcrValidationResult.NEED_BCR_MAINTAINER_REVIEW: The presubmit.yml file of libgit2@1.7.2.bcr.1 doesn't match its previous version libgit2@1.9.2, the following presubmit.yml file change should be reviewed by a BCR maintainer.
--- HEAD
+++ modules/libgit2/1.7.2.bcr.1/presubmit.yml
@@ -26,14 +26,6 @@
- "--@libgit2//:use_https=openssl"
test_targets:
- "@libgit2//..."
- verify_targets_ssh_exec:
- name: Verify build targets (ssh exec)
- platform: ${{ platform }}
- bazel: ${{ bazel }}
- test_flags:
- - "--@libgit2//:use_ssh=exec"
- test_targets:
- - "@libgit2//..."
verify_targets_ssh_libssh2:
name: Verify build targets (ssh libssh2)
platform: ${{ platform }}But this pipeline is not what I would have expected this to be compared against. For BCR versions I would expect the comparison to be against the previous BCR or non-BCR version where the pipeline is identical.
Version
Development (host) and target OS/architectures: N/A
Output of bazel --version: N/A
Version of relevant rules from the WORKSPACE or MODULE.bazel file: N/A
Language(s) and/or frameworks involved: N/A
How to reproduce
Any other information?
No response
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working