Skip to content

[Bug]: Incorrect pipeline comparison in module validation #7832

@UebelAndre

Description

@UebelAndre

What happened?

I opened #7830 and it required a BCR maintainer review per:

https://buildkite.com/bazel/bcr-presubmit/builds/29669/steps/canvas?jid=019cc550-5dfa-4784-a111-088cd7fab084

Validating libgit2@1.7.2.bcr.1
BcrValidationResult.GOOD: The module exists and is recorded in metadata.json.
BcrValidationResult.GOOD: The source URL matches one of the source repositories.
BcrValidationResult.GOOD: The source archive's integrity value matches all provided URLs.
BcrValidationResult.NEED_BCR_MAINTAINER_REVIEW: The presubmit.yml file of libgit2@1.7.2.bcr.1 doesn't match its previous version libgit2@1.9.2, the following presubmit.yml file change should be reviewed by a BCR maintainer.
    --- HEAD
    +++ modules/libgit2/1.7.2.bcr.1/presubmit.yml
    @@ -26,14 +26,6 @@
           - "--@libgit2//:use_https=openssl"
         test_targets:
           - "@libgit2//..."
    -  verify_targets_ssh_exec:
    -    name: Verify build targets (ssh exec)
    -    platform: ${{ platform }}
    -    bazel: ${{ bazel }}
    -    test_flags:
    -      - "--@libgit2//:use_ssh=exec"
    -    test_targets:
    -      - "@libgit2//..."
       verify_targets_ssh_libssh2:
         name: Verify build targets (ssh libssh2)
         platform: ${{ platform }}

But this pipeline is not what I would have expected this to be compared against. For BCR versions I would expect the comparison to be against the previous BCR or non-BCR version where the pipeline is identical.

Version

Development (host) and target OS/architectures: N/A

Output of bazel --version: N/A

Version of relevant rules from the WORKSPACE or MODULE.bazel file: N/A

Language(s) and/or frameworks involved: N/A

How to reproduce

Any other information?

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions