Skip to content

Conversation

@engflow-automation-public
Copy link
Contributor

@bazel-io
Copy link
Member

bazel-io commented Nov 7, 2025

Hello @jayconrod, @WojciechMazur, modules you maintain (gazelle_cc) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds version 0.3.0 of the gazelle_cc module. The changes are mostly correct and follow the Bazel Central Registry guidelines. I've found one issue in the presubmit.yml file regarding the specified Bazel versions for testing, which will likely cause CI failures. Please address the comment to ensure the presubmit checks can pass.

module_path: "example/bzlmod"
matrix:
platform: ["macos", "ubuntu2004"]
bazel: [7.x, 8.x, 9.x]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The Bazel versions 8.x and 9.x are not yet released and are not available in the Bazel Central Registry's CI environment. This will cause presubmit checks to fail. Please use currently available Bazel versions. It's common to test against the current LTS release (7.x) and the rolling version to ensure future compatibility.

    bazel: [7.x, "rolling"]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does 9.x not work? I thought 9.x would work.

@jayconrod
Copy link

I don't understand this error, could someone explain?

FAILED: SLSA verification failed: invalid ref: "1a42c3dca6566cf3a07689768259f1a35066ed01": unexpected ref type: ""

The only occurrence of 1a42c3dca6566cf3a07689768259f1a35066ed01 in gazelle_cc is referencing the publish-to-bcr workflow with the line:

uses: "bazel-contrib/publish-to-bcr/.github/workflows/publish.yaml@1a42c3dca6566cf3a07689768259f1a35066ed01"

We're trying to switch to referring to GitHub actions using only hashes, not mutable tags. But why would that cause an error here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants