Skip to content

Update fastjson module #6498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update fastjson module #6498

wants to merge 4 commits into from
+220 −3

Conversation

@UebelAndre
Copy link
Contributor

@UebelAndre UebelAndre commented Nov 11, 2025

Updated dependencies per conversation on #6441 (comment)

@bazel-io
Copy link
Member

bazel-io commented Nov 11, 2025

Hello @Attempt3035, modules you maintain (fastjson) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 11, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new .bcr.1 version for the fastjson module, introducing an overlay to enable building with Bazel. The overall structure, including the addition of a test module and presubmit.yml, is a good step. However, I've found two critical issues that prevent this from being merged. Firstly, a MODULE.bazel file is present within the overlay directory, which is against Bazel Central Registry (BCR) policy. Secondly, the fastjson-test-srcs cc_library is misconfigured, which will lead to linker errors during the build. Please address these critical findings.

@UebelAndre
Copy link
Contributor Author

UebelAndre commented Nov 11, 2025

@bazel-io skip_check unstable_url

@bazel-io bazel-io added the skip-url-stability-check Skip the URL stability check for the PR label Nov 11, 2025
@Wyverald Wyverald added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@UebelAndre @bazel-io @Wyverald