Adds urdfdom v2.3.4.bcr.1 #6504
Conversation
miker2
commented
Nov 11, 2025
miker2
commented
- Removes 'check_urdf.cpp' from main library srcs
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Hello @Wito-1, modules you maintain (urdfdom) have been updated in this PR. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a new version 2.3.4.bcr.1 for the urdfdom module. The primary change is to correctly package the check_urdf tool as a separate binary instead of including its source in the main library. The new version is well-structured, including the necessary MODULE.bazel, source.json, presubmit.yml, and BUILD.bazel overlay files, and correctly updates the module's metadata.json. The changes align with the Bazel Central Registry contribution guidelines. My review did not identify any high or critical issues.
* Removes 'check_urdf.cpp' from main library srcs
miker2
force-pushed
the
user/mrose/fix-urdfdom
branch
from
f945700 to
dc407c9
Compare
miker2
force-pushed
the
user/mrose/fix-urdfdom
branch
from
9d63836 to
11c8694
Compare
|
@bazel-io skip_check unstable_url |
bazel-io
added
the
skip-url-stability-check
2 participants
