-
Notifications
You must be signed in to change notification settings - Fork 614
Add boost.timer version 1.83.0.bcr.1 #6538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add boost.timer version 1.83.0.bcr.1 #6538
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Hello @vtsao-openai, @Vertexwahn, modules you maintain (boost.timer) have been updated in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds the boost.timer module, version 1.83.0.bcr.1. The structure follows the pattern of other recent boost module additions, including the necessary MODULE.bazel, source.json, presubmit.yml, and an overlay directory with the BUILD.bazel file. The changes are generally well-structured. However, I've identified a significant maintainability concern related to the duplication of the MODULE.bazel file, which I've detailed in the comments. Addressing this will make the module easier to maintain in the future.
0cd5929 to
654110a
Compare
654110a to
53e45cd
Compare
|
@bazel-io skip_check unstable_url |
bazel-io
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.
Require module maintainers' approval for newly pushed changes.
bazel-io
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.
…pendencies are not supporting it (boost.detail 1.83.0.bcr.1)
Require module maintainers' approval for newly pushed changes.
bazel-io
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.
|
@danielflexion there is some failure with Bazel 7 on macos arm64. I'll remove my review since maintainers (@Vertexwahn) already approved (and my questions were answered, thanks) and PR will be merged once the failure is fixed 🤞 [Update]: I'll approve it due to resolving "requested changes". |
Require module maintainers' approval for newly pushed changes.
d3c0624 to
251f457
Compare
251f457 to
437858a
Compare
@kotlaja, @Vertexwahn thanks for the reviews. The mac arm64 error is related to |
Following strcuture added in #4058 without using symlink for MODULE.bazel (#6440).
Adjusted according to other
boost.*1.83.0.bcr.1 targets:presubmit.ymlmatrix.platform list and matrix.bazelplatformsusing version 0.0.10rules_ccusing version 0.0.14Adding @bazel-io skip_check unstable_url as it doesn't have a stable url.