-
Notifications
You must be signed in to change notification settings - Fork 192
Open
Description
Currently if a binary foo internally executes binary bar, then bar's runfiles tree may not be populated as bar can only be added as an input and not as part of the tools.
ctx.actions.run(
outputs = ctx.outputs.outs,
inputs = ctx.files.srcs,
tools = [ctx.executable.tool],
executable = ctx.executable.tool,
arguments = args,
mnemonic = "RunBinary",
use_default_shell_env = False,
env = dicts.add(ctx.configuration.default_shell_env, envs),
)
Instead to ensure it is, it could be better to have:
tools = ctx.executable.tools,
executable = ctx.executable.executable,
This would require a minor change in the attributes in that tool now becomes a list.
Metadata
Metadata
Assignees
Labels
No labels