Skip to content

Commit dcf15c8

Browse files
avdvachew22
authored andcommitted
Remove legacy --cpu flag
1 parent 9df3a83 commit dcf15c8

File tree

1 file changed

+2
-12
lines changed

1 file changed

+2
-12
lines changed

.github/workflows/release.yaml

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -16,40 +16,30 @@ jobs:
1616
artifact: ibazel_linux_amd64
1717
os: ubuntu-latest
1818
build_flags: --platforms=@io_bazel_rules_go//go/toolchain:linux_amd64
19-
cpu_flag:
2019
ext: ""
2120

2221
- name: linux_arm64
2322
artifact: ibazel_linux_arm64
2423
os: ubuntu-latest
2524
build_flags: --platforms=@io_bazel_rules_go//go/toolchain:linux_arm64
26-
cpu_flag:
2725
ext: ""
2826

2927
- name: windows_amd64
3028
artifact: ibazel_windows_amd64.exe
3129
os: ubuntu-latest
3230
build_flags: --platforms=@io_bazel_rules_go//go/toolchain:windows_amd64
33-
cpu_flag:
3431
ext: ".exe"
3532

3633
- name: darwin_amd64
3734
artifact: ibazel_darwin_amd64
3835
os: macos-13
3936
build_flags: --platforms=@io_bazel_rules_go//go/toolchain:darwin_amd64_cgo
40-
# See comment below for more information on this flag.
41-
cpu_flag: --cpu=darwin_amd64
4237
ext: ""
4338

4439
- name: darwin_arm64
4540
artifact: ibazel_darwin_arm64
4641
os: macos-latest
4742
build_flags: --platforms=@io_bazel_rules_go//go/toolchain:darwin_arm64_cgo
48-
# TODO: temporary workaround, remove this in the future.
49-
# Right now, without the flag, GitHub actions build would link to the "darwin_amd64" go_sdk toolchain and fail the build.
50-
# related issue: https://github.com/fsnotify/fsevents/issues/50
51-
# also general info on Bazel platforms: https://bazel.build/concepts/platforms#migration
52-
cpu_flag: --cpu=darwin_arm64
5343
ext: ""
5444

5545
steps:
@@ -59,10 +49,10 @@ jobs:
5949
fetch-depth: 0
6050

6151
- name: Build ibazel
62-
run: bazel build //cmd/ibazel:ibazel --config release ${{ matrix.build_flags }} ${{ matrix.cpu_flag }}
52+
run: bazel build //cmd/ibazel:ibazel --config release ${{ matrix.build_flags }}
6353

6454
- name: Copy binary
65-
run: cp $(bazel info ${{ matrix.cpu_flag }} bazel-bin)/cmd/ibazel/ibazel_/ibazel${{ matrix.ext }} ${{ matrix.artifact }}
55+
run: cp $(bazel info bazel-bin)/cmd/ibazel/ibazel_/ibazel${{ matrix.ext }} ${{ matrix.artifact }}
6656

6757
- name: Upload binary
6858
uses: actions/upload-artifact@v4

0 commit comments

Comments
 (0)