Skycache: Support fake_stamp_data in metadata functionality

This follows ACS changes in unknown commit. This change simply removes the restriction of using the metadata functionality when use_fake_stamp_data=false and sets the value in the request proto.

RELNOTES:none
PiperOrigin-RevId: 839656089
Change-Id: I50083af4d1ac52da1c4700880e932d8c5281a7b8

Author: oquenchil

src/main/java/com/google/devtools/build/lib/buildtool/BuildTool.java

@@ -1077,13 +1077,6 @@ private void tryWriteSkycacheMetadata(
             .analysisCacheEnableMetadataQueries) {
       return;
     }
-    if (!skycacheMetadataParams.getUseFakeStampData()) {
-      // TODO: b/425247333 - Once Skycache handles stamp data well we can remove this check.
-      env.getReporter()
-          .handle(
-              Event.warn("Skycache: Not writing metadata because use_fake_stamp_data is false"));
-      return;
-    }
     try (SilentCloseable c = Profiler.instance().profile("skycache.metadata.upload")) {
       // This is a blocking call. We cannot finish the build until the metadata has been written
       // and at this point there is nothing else to do in the build that could be done in
@@ -1097,6 +1090,7 @@ private void tryWriteSkycacheMetadata(
                 env.getCommandId().toString(),
                 skycacheMetadataParams.getEvaluatingVersion(),
                 skycacheMetadataParams.getConfigurationHash(),
+                skycacheMetadataParams.getUseFakeStampData(),
                 skycacheMetadataParams.getBazelVersion(),
                 skycacheMetadataParams.getTargets(),
                 skycacheMetadataParams.getConfigFlags());
@@ -1709,24 +1703,19 @@ public void queryMetadataAndMaybeBailout() throws InterruptedException {
       if (!areMetadataQueriesEnabled) {
         return;
       }
-      if (skycacheMetadataParams.getUseFakeStampData()) {
-        if (skycacheMetadataParams.getTargets().isEmpty()) {
-          eventHandler.handle(
-              Event.warn(
-                  "Skycache: Not querying Skycache metadata because invocation has no"
-                      + " targets"));
-        } else {
-          getAnalysisCacheClient()
-              .lookupTopLevelTargets(
-                  skycacheMetadataParams.getEvaluatingVersion(),
-                  skycacheMetadataParams.getConfigurationHash(),
-                  skycacheMetadataParams.getBazelVersion(),
-                  eventHandler,
-                  () -> bailedOut = true);
-          }
-      } else {
+      if (skycacheMetadataParams.getTargets().isEmpty()) {
         eventHandler.handle(
-            Event.warn("Skycache: Not querying metadata because use_fake_stamp_data is false"));
+            Event.warn(
+                "Skycache: Not querying Skycache metadata because invocation has no" + " targets"));
+      } else {
+        getAnalysisCacheClient()
+            .lookupTopLevelTargets(
+                skycacheMetadataParams.getEvaluatingVersion(),
+                skycacheMetadataParams.getConfigurationHash(),
+                skycacheMetadataParams.getUseFakeStampData(),
+                skycacheMetadataParams.getBazelVersion(),
+                eventHandler,
+                () -> bailedOut = true);
         }
     }
 

src/main/java/com/google/devtools/build/lib/skyframe/serialization/analysis/RemoteAnalysisCacheClient.java

@@ -43,6 +43,7 @@ record Stats(
   void lookupTopLevelTargets(
       long evaluatingVersion,
       String configurationHash,
+      boolean useFakeStampData,
       String bazelVersion,
       EventHandler eventHandler,
       Runnable bailOutCallback)

src/main/java/com/google/devtools/build/lib/skyframe/serialization/analysis/RemoteAnalysisMetadataWriter.java

@@ -23,6 +23,7 @@ boolean addTopLevelTargets(
       String invocationId,
       long evaluatingVersion,
       String configurationHash,
+      boolean useFakeStampData,
       String blazeVersion,
       Collection<String> targets,
       Collection<String> configFlags)