Add new bazel_first_party and bazel_third_party features

This adds 2 new features based on if the code is being compiled as part
of the main repo, or as part of a third party dependency. This allows
users to customize C++ toolchains (or other rules) based on these
features. This can replace some uses of `--per_file_copt=external/.*@SOMETHING`.

This also allows us to combine features in a way that default toolchain
features can be disabled for third party code. For example you can
disable layering_check for third party code, since you likely don't care
if they correctly define their deps once you're pulling them in.

Author: keith

src/main/java/com/google/devtools/build/lib/skyframe/BUILD

@@ -2412,12 +2412,14 @@ java_library(
         ":repo_file_value",
         ":repository_mapping_value",
         ":sky_functions",
+        "//src/main/java/com/google/devtools/build/lib/analysis/config:feature_set",
         "//src/main/java/com/google/devtools/build/lib/cmdline",
         "//src/main/java/com/google/devtools/build/lib/events",
         "//src/main/java/com/google/devtools/build/lib/packages",
         "//src/main/java/com/google/devtools/build/lib/vfs:pathfragment",
         "//src/main/java/com/google/devtools/build/skyframe:skyframe-objects",
         "//src/main/java/net/starlark/java/eval",
+        "//third_party:guava",
         "//third_party:jsr305",
     ],
 )

src/main/java/com/google/devtools/build/lib/skyframe/RepoPackageArgsFunction.java

@@ -14,6 +14,8 @@
 
 package com.google.devtools.build.lib.skyframe;
 
+import com.google.common.collect.ImmutableSet;
+import com.google.devtools.build.lib.analysis.config.FeatureSet;
 import com.google.devtools.build.lib.cmdline.PackageIdentifier;
 import com.google.devtools.build.lib.cmdline.RepositoryName;
 import com.google.devtools.build.lib.events.Event;
@@ -32,6 +34,14 @@
 
 /** A {@link SkyFunction} that returns the {@link PackageArgs} for a given repository. */
 public class RepoPackageArgsFunction implements SkyFunction {
+  private static final String BAZEL_FIRST_PARTY = "bazel_first_party";
+  private static final String BAZEL_THIRD_PARTY = "bazel_third_party";
+
+  private static final FeatureSet FIRST_PARTY_FEATURES =
+      new FeatureSet(ImmutableSet.of(BAZEL_FIRST_PARTY), ImmutableSet.of());
+  private static final FeatureSet THIRD_PARTY_FEATURES =
+      new FeatureSet(ImmutableSet.of(BAZEL_THIRD_PARTY), ImmutableSet.of());
+
   public static final RepoPackageArgsFunction INSTANCE = new RepoPackageArgsFunction();
 
   /** {@link SkyValue} wrapping a PackageArgs. */
@@ -116,6 +126,8 @@ public SkyValue compute(SkyKey skyKey, Environment env)
         RepoFileFunction.getDisplayNameForRepo(repositoryName, mainRepoMapping.repositoryMapping());
 
     PackageArgs.Builder pkgArgsBuilder = PackageArgs.builder();
+    pkgArgsBuilder.setFeatures(
+        repositoryName.isMain() ? FIRST_PARTY_FEATURES : THIRD_PARTY_FEATURES);
     LabelConverter labelConverter =
         new LabelConverter(
             PackageIdentifier.create(repositoryName, PathFragment.EMPTY_FRAGMENT),

src/test/java/com/google/devtools/build/lib/pkgcache/PackageLoadingTest.java

@@ -665,7 +665,8 @@ public void testPackageFeatures() throws Exception {
         )
         """);
     assertThat(getPackage("peach").getPackageArgs().features())
-        .isEqualTo(FeatureSet.parse(ImmutableList.of("crosstool_default_false")));
+        .isEqualTo(
+            FeatureSet.parse(ImmutableList.of("bazel_first_party", "crosstool_default_false")));
   }
 
   @Test

src/test/java/com/google/devtools/build/lib/skyframe/RepoFileFunctionTest.java

@@ -113,10 +113,78 @@ public void featureMerger() throws Exception {
         """);
     invalidatePackages();
     RuleContext ruleContext = getRuleContext(getConfiguredTarget("//abc/def:what"));
-    assertThat(ruleContext.getFeatures()).containsExactly("b", "c", "d");
+    assertThat(ruleContext.getFeatures()).containsExactly("b", "c", "d", "bazel_first_party");
     assertThat(ruleContext.getDisabledFeatures()).containsExactly("a");
   }
 
+  @Test
+  public void mainRepoHasFirstPartyFeature() throws Exception {
+    scratch.overwriteFile("REPO.bazel", "");
+    scratch.overwriteFile("abc/BUILD", "filegroup(name='t')");
+    invalidatePackages();
+    RuleContext ruleContext = getRuleContext(getConfiguredTarget("//abc:t"));
+    assertThat(ruleContext.getFeatures()).contains("bazel_first_party");
+    assertThat(ruleContext.getFeatures()).doesNotContain("bazel_third_party");
+  }
+
+  @Test
+  public void mainRepoHasFirstPartyFeatureWithNoRepoFile() throws Exception {
+    scratch.overwriteFile("abc/BUILD", "filegroup(name='t')");
+    invalidatePackages();
+    RuleContext ruleContext = getRuleContext(getConfiguredTarget("//abc:t"));
+    assertThat(ruleContext.getFeatures()).contains("bazel_first_party");
+    assertThat(ruleContext.getFeatures()).doesNotContain("bazel_third_party");
+  }
+
+  @Test
+  public void externalRepoHasThirdPartyFeature() throws Exception {
+    scratch.overwriteFile("MODULE.bazel", "bazel_dep(name='foo',version='1.0')");
+    registry.addModule(createModuleKey("foo", "1.0"), "module(name='foo',version='1.0')");
+    scratch.overwriteFile(
+        moduleRoot.getRelative("foo+1.0/MODULE.bazel").getPathString(), "");
+    scratch.overwriteFile(
+        moduleRoot.getRelative("foo+1.0/abc/BUILD").getPathString(), "filegroup(name='t')");
+    invalidatePackages();
+    RuleContext ruleContext = getRuleContext(getConfiguredTarget("@@foo+//abc:t"));
+    assertThat(ruleContext.getFeatures()).contains("bazel_third_party");
+    assertThat(ruleContext.getFeatures()).doesNotContain("bazel_first_party");
+  }
+
+  @Test
+  public void firstPartyFeatureCanBeDisabledByRepoFile() throws Exception {
+    scratch.overwriteFile("REPO.bazel", "repo(features=['-bazel_first_party'])");
+    scratch.overwriteFile("abc/BUILD", "filegroup(name='t')");
+    invalidatePackages();
+    RuleContext ruleContext = getRuleContext(getConfiguredTarget("//abc:t"));
+    assertThat(ruleContext.getFeatures()).doesNotContain("bazel_first_party");
+    assertThat(ruleContext.getDisabledFeatures()).contains("bazel_first_party");
+  }
+
+  @Test
+  public void thirdPartyFeatureCanBeDisabledByRepoFile() throws Exception {
+    scratch.overwriteFile("MODULE.bazel", "bazel_dep(name='foo',version='1.0')");
+    registry.addModule(createModuleKey("foo", "1.0"), "module(name='foo',version='1.0')");
+    scratch.overwriteFile(
+        moduleRoot.getRelative("foo+1.0/REPO.bazel").getPathString(),
+        "repo(features=['-bazel_third_party'])");
+    scratch.overwriteFile(
+        moduleRoot.getRelative("foo+1.0/abc/BUILD").getPathString(), "filegroup(name='t')");
+    invalidatePackages();
+    RuleContext ruleContext = getRuleContext(getConfiguredTarget("@@foo+//abc:t"));
+    assertThat(ruleContext.getFeatures()).doesNotContain("bazel_third_party");
+    assertThat(ruleContext.getDisabledFeatures()).contains("bazel_third_party");
+  }
+
+  @Test
+  public void firstPartyFeatureMergesWithUserFeatures() throws Exception {
+    scratch.overwriteFile("REPO.bazel", "repo(features=['custom_feature'])");
+    scratch.overwriteFile("abc/BUILD", "filegroup(name='t')");
+    invalidatePackages();
+    RuleContext ruleContext = getRuleContext(getConfiguredTarget("//abc:t"));
+    assertThat(ruleContext.getFeatures()).contains("bazel_first_party");
+    assertThat(ruleContext.getFeatures()).contains("custom_feature");
+  }
+
   @Test
   public void restrictedSyntax() throws Exception {
     scratch.overwriteFile(

src/test/java/com/google/devtools/build/lib/starlark/StarlarkRuleContextTest.java

@@ -1130,7 +1130,7 @@ public void testConfiguration() throws Exception {
   public void testFeatures() throws Exception {
     setRuleContext(createRuleContext("//foo:cc_with_features"));
     Object result = ev.eval("ruleContext.features");
-    assertThat((Sequence) result).containsExactly("f1", "f2");
+    assertThat((Sequence) result).containsExactly("bazel_first_party", "f1", "f2");
   }
 
   @Test