Skip to content

Commit 51161db

Browse files
aoeuicopybara-github
authored andcommitted
Delete redundant @AutoCodec annotation on NonRuleConfiguredTargetValue.
The ConfiguredTargetValueCodec already provides serialization for NonRuleConfiguredTargetValue. Adds clarifying comments. PiperOrigin-RevId: 840366686 Change-Id: I53e8d8ec7412bf752f8f816944953ab92de044dc
1 parent e2b5f81 commit 51161db

File tree

1 file changed

+3
-15
lines changed

1 file changed

+3
-15
lines changed

src/main/java/com/google/devtools/build/lib/skyframe/NonRuleConfiguredTargetValue.java

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -13,41 +13,29 @@
1313
// limitations under the License.
1414
package com.google.devtools.build.lib.skyframe;
1515

16-
1716
import com.google.common.base.MoreObjects;
1817
import com.google.devtools.build.lib.analysis.ConfiguredTarget;
1918
import com.google.devtools.build.lib.analysis.ConfiguredTargetValue;
20-
import com.google.devtools.build.lib.analysis.configuredtargets.RuleConfiguredTarget;
2119
import com.google.devtools.build.lib.collect.nestedset.NestedSet;
2220
import com.google.devtools.build.lib.concurrent.ThreadSafety.Immutable;
2321
import com.google.devtools.build.lib.concurrent.ThreadSafety.ThreadSafe;
2422
import com.google.devtools.build.lib.packages.Package;
2523
import com.google.devtools.build.lib.packages.TargetData;
26-
import com.google.devtools.build.lib.skyframe.serialization.VisibleForSerialization;
27-
import com.google.devtools.build.lib.skyframe.serialization.autocodec.AutoCodec;
2824
import javax.annotation.Nullable;
2925

3026
/** A non-rule configured target in the context of a Skyframe graph. */
3127
@Immutable
3228
@ThreadSafe
33-
// Reached via all ConfiguredTarget implementations except RuleConfiguredTarget.
34-
@AutoCodec(explicitlyAllowClass = RuleConfiguredTarget.class)
3529
public final class NonRuleConfiguredTargetValue
3630
extends AbstractConfiguredTargetValue<ConfiguredTarget> implements ConfiguredTargetValue {
3731

38-
private TargetData targetData;
39-
40-
@AutoCodec.Instantiator
41-
@VisibleForSerialization
42-
NonRuleConfiguredTargetValue(
43-
ConfiguredTarget configuredTarget) {
44-
// Transitive packages are not serialized.
45-
this(configuredTarget, null);
46-
}
32+
@Nullable // Non-null when this is an alias of a remotely fetched ConfiguredTarget.
33+
private final TargetData targetData;
4734

4835
NonRuleConfiguredTargetValue(
4936
ConfiguredTarget configuredTarget, @Nullable NestedSet<Package.Metadata> transitivePackages) {
5037
super(configuredTarget, transitivePackages);
38+
this.targetData = null;
5139
}
5240

5341
NonRuleConfiguredTargetValue(

0 commit comments

Comments
 (0)