Add some profiling spans for slow null builds with Skycache

- `initAnalysisCacheClient`: Creating the `analysisCacheClient` the first time in each invocation is slow because we re-establish the RPC connection (accounts for ~1.1s). This isn't super straightforward to fix, but at least adding a profile span here will cover a thus far "unexplained" timespan.

- `getDeserializedKeys`: This is the part where we dig up all SkyKeys that were deserialized instead of directly evaluated, and invalidate them. Compared to `initAnalysisCacheClient` above, this is usually not very big.
  - Also applied a minor optimization here: `getDoneValues()` produces a filtered view of the `InMemoryGraph`, which we then filtered further using `parallelStream()`. We could just filter once by directly calling `getAllNodeEntries()` instead.

PiperOrigin-RevId: 882580327
Change-Id: Ia4e2282a9158d5c66801d942ffba58128e6387ac

Author: Wyverald

src/main/java/com/google/devtools/build/lib/skyframe/SkyframeExecutor.java

@@ -314,7 +314,6 @@
 import java.util.LinkedHashMap;
 import java.util.List;
 import java.util.Map;
-import java.util.Map.Entry;
 import java.util.Optional;
 import java.util.Set;
 import java.util.TreeSet;
@@ -612,11 +611,14 @@ public void invalidateWithExternalService(ExtendedEventHandler eventHandler)
       return;
     }
 
-    ImmutableSet<SkyKey> keysToLookup =
-        getEvaluator().getDoneValues().entrySet().parallelStream()
-            .filter(e -> e.getValue() instanceof DeserializedSkyValue)
-            .map(Entry::getKey)
-            .collect(toImmutableSet());
+    ImmutableSet<SkyKey> keysToLookup;
+    try (SilentCloseable c = Profiler.instance().profile("getDeserializedKeys")) {
+      keysToLookup =
+          getEvaluator().getInMemoryGraph().getAllNodeEntries().parallelStream()
+              .filter(e -> e.isDone() && e.getValue() instanceof DeserializedSkyValue)
+              .map(InMemoryNodeEntry::getKey)
+              .collect(toImmutableSet());
+    }
 
     if (!remoteAnalysisCachingCurrentlyEnabled) {
       // If skycache is currently disabled, we need to delete all the deserialized nodes

src/main/java/com/google/devtools/build/lib/skyframe/serialization/analysis/BUILD

@@ -384,6 +384,7 @@ java_library(
         "//src/main/java/com/google/devtools/build/lib/events",
         "//src/main/java/com/google/devtools/build/lib/packages",
         "//src/main/java/com/google/devtools/build/lib/pkgcache:package_path_codec_dependencies",
+        "//src/main/java/com/google/devtools/build/lib/profiler",
         "//src/main/java/com/google/devtools/build/lib/runtime:blaze_command_cluster",
         "//src/main/java/com/google/devtools/build/lib/runtime:instrumentation_output",
         "//src/main/java/com/google/devtools/build/lib/skyframe:prerequisite_package_function",

src/main/java/com/google/devtools/build/lib/skyframe/serialization/analysis/RemoteAnalysisCacheManager.java

@@ -47,6 +47,8 @@
 import com.google.devtools.build.lib.events.ExtendedEventHandler;
 import com.google.devtools.build.lib.packages.RuleClassProvider;
 import com.google.devtools.build.lib.pkgcache.PackagePathCodecDependencies;
+import com.google.devtools.build.lib.profiler.Profiler;
+import com.google.devtools.build.lib.profiler.SilentCloseable;
 import com.google.devtools.build.lib.runtime.CommandEnvironment;
 import com.google.devtools.build.lib.runtime.InstrumentationOutput;
 import com.google.devtools.build.lib.runtime.InstrumentationOutputFactory.DestinationRelativeTo;
@@ -265,7 +267,11 @@ public static AnalysisDeps forAnalysis(
       case RemoteAnalysisCacheMode.DUMP_UPLOAD_MANIFEST_ONLY, RemoteAnalysisCacheMode.UPLOAD ->
           new AnalysisDeps(manager, deps, deps);
       case RemoteAnalysisCacheMode.DOWNLOAD -> {
-        if (deps.getAnalysisCacheClient() == null) {
+        RemoteAnalysisCacheClient analysisCacheClient;
+        try (SilentCloseable unused = Profiler.instance().profile("initAnalysisCacheClient")) {
+          analysisCacheClient = deps.getAnalysisCacheClient();
+        }
+        if (analysisCacheClient == null) {
           if (Strings.isNullOrEmpty(options.analysisCacheService)) {
             env.getReporter()
                 .handle(
@@ -278,7 +284,7 @@ public static AnalysisDeps forAnalysis(
                 .handle(
                     Event.warn(
                         "Failed to establish connection to AnalysisCacheService. Falling back to"
-                            + " on local evaluation."));
+                            + " local evaluation."));
           }
           yield new AnalysisDeps(
               DisabledDependenciesProvider.INSTANCE,