Skip to content

Commit abfa036

Browse files
tjgqcopybara-github
authored andcommitted
Internal change
PiperOrigin-RevId: 837124434 Change-Id: I35f4ee085410e552eb303f980cf237d38ee51503
1 parent f6356d6 commit abfa036

File tree

8 files changed

+55
-25
lines changed

8 files changed

+55
-25
lines changed

src/main/java/com/google/devtools/build/lib/buildeventservice/BUILD

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ filegroup(
1212
)
1313

1414
java_library(
15-
name = "BuildEventServiceAvailabilityEvent",
15+
name = "build_event_service_availability_event",
1616
srcs = ["BuildEventServiceAvailabilityEvent.java"],
1717
deps = [
1818
"//src/main/java/com/google/devtools/build/lib/util:exit_code",
@@ -22,7 +22,7 @@ java_library(
2222
)
2323

2424
java_library(
25-
name = "buildeventservice-options",
25+
name = "build_event_service_options",
2626
srcs = ["BuildEventServiceOptions.java"],
2727
deps = [
2828
"//src/main/java/com/google/devtools/common/options",
@@ -33,18 +33,23 @@ java_library(
3333
name = "buildeventservice",
3434
srcs = glob(
3535
["*.java"],
36-
exclude = ["BuildEventServiceOptions.java"],
36+
exclude = [
37+
"BuildEventServiceOptions.java",
38+
"BuildEventServiceAvailabilityEvent.java",
39+
],
3740
),
3841
deps = [
39-
":buildeventservice-options",
42+
":build_event_service_availability_event",
43+
":build_event_service_options",
4044
"//src/main/java/com/google/devtools/build/lib:runtime",
4145
"//src/main/java/com/google/devtools/build/lib/analysis:blaze_directories",
4246
"//src/main/java/com/google/devtools/build/lib/analysis:test/test_configuration",
4347
"//src/main/java/com/google/devtools/build/lib/authandtls",
4448
"//src/main/java/com/google/devtools/build/lib/authandtls/credentialhelper",
4549
"//src/main/java/com/google/devtools/build/lib/authandtls/credentialhelper:credential_module",
4650
"//src/main/java/com/google/devtools/build/lib/bugreport",
47-
"//src/main/java/com/google/devtools/build/lib/buildeventservice/client",
51+
"//src/main/java/com/google/devtools/build/lib/buildeventservice/client:build_event_service_client",
52+
"//src/main/java/com/google/devtools/build/lib/buildeventservice/client:build_event_service_grpc_client",
4853
"//src/main/java/com/google/devtools/build/lib/buildeventstream",
4954
"//src/main/java/com/google/devtools/build/lib/buildeventstream:build_event_service_upload_complete_event",
5055
"//src/main/java/com/google/devtools/build/lib/buildeventstream:large-buildevent-serialized-event",

src/main/java/com/google/devtools/build/lib/buildeventservice/client/BUILD

Lines changed: 29 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,22 +12,45 @@ filegroup(
1212
)
1313

1414
java_library(
15-
name = "client",
16-
srcs = glob(["*.java"]),
15+
name = "build_event_service_client",
16+
srcs = ["BuildEventServiceClient.java"],
17+
deps = [
18+
"//third_party:auto_value",
19+
"//third_party:error_prone_annotations",
20+
"//third_party:guava",
21+
"//third_party:jsr305",
22+
"//third_party/grpc-java:grpc-jar",
23+
"@com_google_protobuf//:protobuf_java",
24+
],
25+
)
26+
27+
java_library(
28+
name = "build_event_service_grpc_client",
29+
srcs = ["BuildEventServiceGrpcClient.java"],
1730
runtime_deps = [
1831
# This is required for client TLS.
1932
"//third_party:netty_tcnative",
2033
],
2134
deps = [
22-
"//src/main/java/com/google/devtools/build/lib/buildeventstream/proto:build_event_stream_java_proto",
35+
":build_event_service_client",
36+
":build_event_service_proto_util",
2337
"//src/main/java/com/google/devtools/build/lib/remote/util",
24-
"//third_party:auto_value",
25-
"//third_party:error_prone_annotations",
2638
"//third_party:guava",
2739
"//third_party:jsr305",
2840
"//third_party/grpc-java:grpc-jar",
29-
"@com_google_protobuf//:protobuf_java",
3041
"@googleapis//google/devtools/build/v1:build_java_grpc",
3142
"@googleapis//google/devtools/build/v1:build_java_proto",
3243
],
3344
)
45+
46+
java_library(
47+
name = "build_event_service_proto_util",
48+
srcs = ["BuildEventServiceProtoUtil.java"],
49+
deps = [
50+
":build_event_service_client",
51+
"//src/main/java/com/google/devtools/build/lib/buildeventstream/proto:build_event_stream_java_proto",
52+
"//third_party:guava",
53+
"@com_google_protobuf//:protobuf_java",
54+
"@googleapis//google/devtools/build/v1:build_java_proto",
55+
],
56+
)

src/main/java/com/google/devtools/build/lib/buildeventstream/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ java_library(
2424
deps = [
2525
"//src/main/java/com/google/devtools/build/lib/actions:artifacts",
2626
"//src/main/java/com/google/devtools/build/lib/actions:file_metadata",
27-
"//src/main/java/com/google/devtools/build/lib/buildeventservice:buildeventservice-options",
27+
"//src/main/java/com/google/devtools/build/lib/buildeventservice:build_event_service_options",
2828
"//src/main/java/com/google/devtools/build/lib/buildeventstream/proto:build_event_stream_java_proto",
2929
"//src/main/java/com/google/devtools/build/lib/cmdline",
3030
"//src/main/java/com/google/devtools/build/lib/collect/nestedset",

src/main/java/com/google/devtools/build/lib/buildeventstream/transports/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ java_library(
1515
name = "transports",
1616
srcs = glob(["*.java"]),
1717
deps = [
18-
"//src/main/java/com/google/devtools/build/lib/buildeventservice:buildeventservice-options",
18+
"//src/main/java/com/google/devtools/build/lib/buildeventservice:build_event_service_options",
1919
"//src/main/java/com/google/devtools/build/lib/buildeventstream",
2020
"//src/main/java/com/google/devtools/build/lib/buildeventstream/proto:build_event_stream_java_proto",
2121
"//src/main/java/com/google/devtools/build/lib/util:abrupt_exit_exception",

src/test/java/com/google/devtools/build/lib/buildeventservice/AbstractBuildEventServiceTransportTest.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,6 @@
7070
import com.google.devtools.build.lib.vfs.inmemoryfs.InMemoryFileSystem;
7171
import com.google.devtools.build.v1.PublishBuildToolEventStreamRequest;
7272
import com.google.devtools.common.options.Options;
73-
import com.google.devtools.common.options.OptionsParsingException;
7473
import com.google.protobuf.Any;
7574
import com.google.protobuf.ByteString;
7675
import io.grpc.Status;
@@ -928,15 +927,14 @@ private static void assertExecutionException(
928927

929928
protected abstract AbstractBuildEventRecorder createBesServer();
930929

931-
protected abstract BuildEventServiceClient createBesClient() throws OptionsParsingException;
930+
protected abstract BuildEventServiceClient createBesClient() throws IOException;
932931

933-
protected abstract BuildEventServiceClient createBesClient(int serverPort)
934-
throws OptionsParsingException;
932+
protected abstract BuildEventServiceClient createBesClient(int serverPort) throws IOException;
935933

936934
protected abstract DigestHashFunction makeVfsHashFunction();
937935

938936
private BuildEventServiceTransport newBuildEventServiceTransport(boolean publishLifecycleEvents)
939-
throws OptionsParsingException {
937+
throws IOException {
940938
return newBuildEventServiceTransport(
941939
createBesClient(), publishLifecycleEvents, Duration.ZERO, new LocalFilesArtifactUploader());
942940
}

src/test/java/com/google/devtools/build/lib/buildeventservice/BUILD

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,9 @@ java_library(
2424
deps = [
2525
"//src/main/java/com/google/devtools/build/lib:runtime",
2626
"//src/main/java/com/google/devtools/build/lib/buildeventservice",
27-
"//src/main/java/com/google/devtools/build/lib/buildeventservice:buildeventservice-options",
28-
"//src/main/java/com/google/devtools/build/lib/buildeventservice/client",
27+
"//src/main/java/com/google/devtools/build/lib/buildeventservice:build_event_service_options",
28+
"//src/main/java/com/google/devtools/build/lib/buildeventservice/client:build_event_service_client",
29+
"//src/main/java/com/google/devtools/build/lib/buildeventservice/client:build_event_service_proto_util",
2930
"//src/main/java/com/google/devtools/build/lib/buildeventstream",
3031
"//src/main/java/com/google/devtools/build/lib/buildeventstream/proto:build_event_stream_java_proto",
3132
"//src/main/java/com/google/devtools/build/lib/clock",
@@ -60,7 +61,9 @@ java_test(
6061
test_class = "com.google.devtools.build.lib.AllTests",
6162
runtime_deps = ["//src/test/java/com/google/devtools/build/lib:test_runner"],
6263
deps = [
63-
"//src/main/java/com/google/devtools/build/lib/buildeventservice/client",
64+
"//src/main/java/com/google/devtools/build/lib/buildeventservice/client:build_event_service_client",
65+
"//src/main/java/com/google/devtools/build/lib/buildeventservice/client:build_event_service_grpc_client",
66+
"//src/main/java/com/google/devtools/build/lib/buildeventservice/client:build_event_service_proto_util",
6467
"//src/test/java/com/google/devtools/build/lib/testutil",
6568
"//third_party:guava",
6669
"//third_party:junit4",
@@ -77,7 +80,8 @@ java_test(
7780
srcs = ["BuildEventServiceTransportGrpcTest.java"],
7881
deps = [
7982
":AbstractBuildEventServiceTransportTest",
80-
"//src/main/java/com/google/devtools/build/lib/buildeventservice/client",
83+
"//src/main/java/com/google/devtools/build/lib/buildeventservice/client:build_event_service_client",
84+
"//src/main/java/com/google/devtools/build/lib/buildeventservice/client:build_event_service_grpc_client",
8185
"//src/main/java/com/google/devtools/build/lib/util:pair",
8286
"//src/main/java/com/google/devtools/build/lib/vfs",
8387
"//src/test/java/com/google/devtools/build/lib/remote/util:free_port_finder",
@@ -105,7 +109,7 @@ java_test(
105109
"//src/main/java/com/google/devtools/build/lib/authandtls/credentialhelper:credential_module",
106110
"//src/main/java/com/google/devtools/build/lib/bugreport",
107111
"//src/main/java/com/google/devtools/build/lib/buildeventservice",
108-
"//src/main/java/com/google/devtools/build/lib/buildeventservice:buildeventservice-options",
112+
"//src/main/java/com/google/devtools/build/lib/buildeventservice:build_event_service_options",
109113
"//src/main/java/com/google/devtools/build/lib/buildeventstream",
110114
"//src/main/java/com/google/devtools/build/lib/buildeventstream:build_event_service_upload_complete_event",
111115
"//src/main/java/com/google/devtools/build/lib/buildeventstream/proto:build_event_stream_java_proto",

src/test/java/com/google/devtools/build/lib/buildeventstream/transports/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ java_test(
1919
test_class = "com.google.devtools.build.lib.AllTests",
2020
runtime_deps = ["//src/test/java/com/google/devtools/build/lib:test_runner"],
2121
deps = [
22-
"//src/main/java/com/google/devtools/build/lib/buildeventservice:buildeventservice-options",
22+
"//src/main/java/com/google/devtools/build/lib/buildeventservice:build_event_service_options",
2323
"//src/main/java/com/google/devtools/build/lib/buildeventstream",
2424
"//src/main/java/com/google/devtools/build/lib/buildeventstream/proto:build_event_stream_java_proto",
2525
"//src/main/java/com/google/devtools/build/lib/buildeventstream/transports",

src/test/java/com/google/devtools/build/lib/runtime/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ java_library(
7070
"//src/main/java/com/google/devtools/build/lib/bazel/repository/downloader",
7171
"//src/main/java/com/google/devtools/build/lib/bazel/rules",
7272
"//src/main/java/com/google/devtools/build/lib/bugreport",
73-
"//src/main/java/com/google/devtools/build/lib/buildeventservice:buildeventservice-options",
73+
"//src/main/java/com/google/devtools/build/lib/buildeventservice:build_event_service_options",
7474
"//src/main/java/com/google/devtools/build/lib/buildeventstream",
7575
"//src/main/java/com/google/devtools/build/lib/buildeventstream/proto:build_event_stream_java_proto",
7676
"//src/main/java/com/google/devtools/build/lib/buildeventstream/transports",

0 commit comments

Comments
 (0)