Do all initialization in forAnalysis() instead of constructors and set the top-level configuration options from an argument to forAnalysis().

This lets us decouple RemoteAnalysisCacheManager and RemoteAnalysisCacheDeps and remove quite a few constructor parameters and fields.

RELNOTES: None.
PiperOrigin-RevId: 875870230
Change-Id: I8dc8cc034b842e568d319c2017a8013597ad83c5

Author: lberki

src/main/java/com/google/devtools/build/lib/analysis/BuildView.java

@@ -329,10 +329,6 @@ public AnalysisResult update(
     if (buildConfigurationsCreatedCallback != null) {
       buildConfigurationsCreatedCallback.run(topLevelConfig);
     }
-    if (remoteAnalysisCachingDependenciesProvider.mode().requiresBackendConnectivity()) {
-      remoteAnalysisCachingDependenciesProvider.setTopLevelBuildOptions(
-          topLevelConfigurationTrimmedOfTestOptions);
-    }
     if (remoteAnalysisCachingDependenciesProvider.mode() == RemoteAnalysisCacheMode.DOWNLOAD) {
       try (SilentCloseable c = Profiler.instance().profile("skycache.metadataQuery")) {
         remoteAnalysisCachingDependenciesProvider.queryMetadataAndMaybeBailout();

src/main/java/com/google/devtools/build/lib/buildtool/BuildTool.java

@@ -36,6 +36,7 @@
 import com.google.devtools.build.lib.actions.TestExecException;
 import com.google.devtools.build.lib.analysis.AnalysisAndExecutionResult;
 import com.google.devtools.build.lib.analysis.AnalysisResult;
+import com.google.devtools.build.lib.analysis.BuildView;
 import com.google.devtools.build.lib.analysis.ConfiguredTarget;
 import com.google.devtools.build.lib.analysis.ViewCreationFailedException;
 import com.google.devtools.build.lib.analysis.actions.TemplateExpansionException;
@@ -364,6 +365,8 @@ public void buildTargets(
               env,
               projectEvaluationResult.activeDirectoriesMatcher(),
               targetPatternPhaseValue.getTargetLabels(),
+              BuildView.getTopLevelConfigurationTrimmedOfTestOptions(
+                  buildOptions, env.getReporter()),
               request.getUserOptions(),
               projectEvaluationResult.buildOptions());
       analysisCachingDeps = analysisDeps.deps();

src/main/java/com/google/devtools/build/lib/skyframe/serialization/analysis/BUILD

@@ -38,7 +38,6 @@ java_library(
         ":remote_analysis_caching_server_state",
         ":remote_analysis_json_log_writer",
         ":remote_analysis_metadata_writer",
-        "//src/main/java/com/google/devtools/build/lib/analysis/config:build_options",
         "//src/main/java/com/google/devtools/build/lib/cmdline",
         "//src/main/java/com/google/devtools/build/lib/skyframe/serialization",
         "//src/main/java/com/google/devtools/build/lib/skyframe/serialization:frontier_node_version",