Skip to content

Commit 1f9f8e8

Browse files
authored
Don't flatten a depset unnecessarily (#628)
1 parent dd4c4bf commit 1f9f8e8

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

rules/depsets/foo.bzl

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,15 @@ def _foo_binary_impl(ctx):
3434
foocc = ctx.executable._foocc
3535
out = ctx.outputs.out
3636
trans_srcs = get_transitive_srcs(ctx.files.srcs, ctx.attr.deps)
37-
srcs_list = trans_srcs.to_list()
37+
38+
args = ctx.actions.args()
39+
args.add(out)
40+
args.add_all(trans_srcs)
41+
3842
ctx.actions.run(
3943
executable = foocc,
40-
arguments = [out.path] + [src.path for src in srcs_list],
41-
inputs = srcs_list,
44+
arguments = [args],
45+
inputs = trans_srcs,
4246
tools = [foocc],
4347
outputs = [out],
4448
)

0 commit comments

Comments
 (0)