Skip to content

Commit 988adb4

Browse files
A Googlercopybara-github
authored andcommitted
do not iterate over deps
Fixes break "type 'select' is not iterable" PiperOrigin-RevId: 582319381 Change-Id: I7da9bf219426c1d28cfca036b039c6fb47e43b44
1 parent b7870f6 commit 988adb4

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

rules/android_application/android_application_rule.bzl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -453,12 +453,12 @@ def android_application_macro(_android_binary, **attrs):
453453
# In the future bundle_config will accept a build rule rather than a raw file.
454454
bundle_config_file = bundle_config_file or bundle_config
455455

456-
deps = [d for d in attrs.pop("deps", [])]
456+
deps = attrs.pop("deps", [])
457457
for feature_module in feature_modules:
458458
if not feature_module.startswith("//") or ":" not in feature_module:
459459
_log.error("feature_modules expects fully qualified paths, i.e. //some/path:target")
460460
module_targets = get_feature_module_paths(feature_module)
461-
deps.append(str(module_targets.title_lib))
461+
deps = deps + [str(module_targets.title_lib)]
462462

463463
_android_binary(
464464
name = base_split_name,

0 commit comments

Comments
 (0)