Apply the Starlark Android Platforms Transition.

This applies the transition everywhere in the Android Rules where the native transition is currently applied. It also applies the transition to android_binary_internal which currently has no transition applied. Applying the transition is required for fullying Starlarkifying android_binary. This is a slight behavior change for android_binary_internal. However, since android_instrumentation_test already applies the transition, many android_binary_internal targets are already running in this config.

PiperOrigin-RevId: 582713784
Change-Id: I454bc0ee588068de98615c9da0cf9d3da3287b4e

Author: ajsinclair

rules/android_application/BUILD

@@ -22,6 +22,7 @@ bzl_library(
     name = "bzl",
     srcs = glob(["*.bzl"]),
     deps = [
+        "//rules:android_platforms_transition_bzl",
         "//rules:common_bzl",
         "//rules/android_sandboxed_sdk:bzl",
         "//rules/flags:bzl",

rules/android_application/android_application_rule.bzl

@@ -19,6 +19,7 @@ load(
     _aapt = "aapt",
 )
 load("//rules:acls.bzl", _acls = "acls")
+load("//rules:android_platforms_transition.bzl", "android_platforms_transition")
 load(
     "//rules:bundletool.bzl",
     _bundletool = "bundletool",
@@ -388,7 +389,7 @@ def _impl(ctx):
 
 android_application = rule(
     attrs = ANDROID_APPLICATION_ATTRS,
-    cfg = android_common.android_platforms_transition,
+    cfg = android_platforms_transition,
     fragments = [
         "android",
         "java",

rules/android_binary_internal/BUILD

@@ -12,9 +12,10 @@ filegroup(
 bzl_library(
     name = "bzl",
     srcs = glob(["*.bzl"]),
+    visibility = ["//:__subpackages__"],
     deps = [
+        "//rules:android_platforms_transition_bzl",
         "//rules:android_split_transition_bzl",
         "//rules:common_bzl",
     ],
-    visibility = ["//:__subpackages__"],
 )

rules/android_binary_internal/rule.bzl

@@ -14,12 +14,13 @@
 
 """Starlark Android Binary for Android Rules."""
 
-load(":attrs.bzl", "ATTRS")
-load(":impl.bzl", "impl")
+load("//rules:android_platforms_transition.bzl", "android_platforms_transition")
 load(
     "//rules:attrs.bzl",
     _attrs = "attrs",
 )
+load(":attrs.bzl", "ATTRS")
+load(":impl.bzl", "impl")
 
 _DEFAULT_ALLOWED_ATTRS = ["name", "visibility", "tags", "testonly", "transitive_configs", "$enable_manifest_merging", "features", "exec_properties"]
 
@@ -56,6 +57,7 @@ def make_rule(
             "java",
             "cpp",
         ],
+        cfg = android_platforms_transition,
     )
 
 android_binary_internal = make_rule()