Restore (limited) dynamic feature capability + introduce sample app #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviernotteghem
force-pushed
the
df_prep
branch
from
37c5f5d to
9383f01
Compare
oliviernotteghem
force-pushed
the
df_prep
branch
from
9383f01 to
8452f18
Compare
|
Thanks, I've started importing this so we can have it for the 0.6.0 release |
|
One issue is that the bundle manifest validator relies on xmllint to extract info from the bundle manifest, and that tool is not installed on bazelci runner images (and we probably shouldn't depend on locally installed tools anyway). So we either have to find a way to get xmllint (for linux, mac, and windows), or build the minimal functionality for extracting the xml info into something in rules_android ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes (presumably obsolete) application bundle code :
xmllinttool target. This tool is used during dynamic feature manifest.xml validation.android_feature_modulerule, so that it can be used in application bundle project.fusedattribute. This attribute is used internally byandroid_feature_modulerules and has to be declared.android_feature_module. UsingLabel()doesn't account for external usage._merge_manifestsdefault attribute value used byandroid_application. Current value is bogus.A sample application is also provided to build a simple application bundle, whose dynamic feature contain one asset file (assets.txt). To build it :
cd examples/bundle && bazel build app:assets