Skip to content

Commit 93ade5e

Browse files
authored
Properly close files after read/write (#2176)
1 parent 6b599e8 commit 93ade5e

File tree

2 files changed

+12
-0
lines changed

2 files changed

+12
-0
lines changed

container/go/cmd/zipper/zipper.go

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,10 +49,21 @@ func main() {
4949
if err != nil {
5050
log.Fatalf("Unable to read input file: %v", err)
5151
}
52+
defer func() {
53+
if err := f.Close(); err != nil {
54+
log.Fatalf("Unable to close %q: %v", *src, err)
55+
}
56+
}()
57+
5258
t, err := os.Create(*dst)
5359
if err != nil {
5460
log.Fatalf("Unable to create output file: %v", err)
5561
}
62+
defer func() {
63+
if err := t.Close(); err != nil {
64+
log.Fatalf("Unable to close %q: %v", *dst, err)
65+
}
66+
}()
5667

5768
if *decompress {
5869
zr, err := gzip.NewReader(f)

container/go/pkg/compat/write.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,7 @@ func writeImageLayer(l v1.Layer, idx int, outDir string) error {
102102
if err != nil {
103103
return errors.Wrapf(err, "unable to create %s to write layer %d", outLayerFile, idx)
104104
}
105+
defer o.Close()
105106
if _, err := io.Copy(o, contents); err != nil {
106107
return errors.Wrapf(err, "unable to write the contents of layer %d to %s", idx, outLayerFile)
107108
}

0 commit comments

Comments
 (0)