Skip to content

fix(nodejs): remove node binary from layers #1503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thesayyn wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −9
Open

fix(nodejs): remove node binary from layers #1503

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions nodejs/image.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,22 +136,14 @@ def nodejs_image(
**kwargs
)

nodejs_layers = [
# Put the Node binary into its own layers.
"@nodejs//:node",
"@nodejs//:node_files",
"@nodejs//:bin/node_repo_args.sh",
]

all_layers = nodejs_layers + layers

visibility = kwargs.get("visibility", None)
tags = kwargs.get("tags", None)

# TODO(mattmoor): Consider making the directory into which the app
# is placed configurable.
base = base or DEFAULT_BASE
for index, dep in enumerate(all_layers):
for index, dep in enumerate(layers):
this_name = "%s.%d" % (name, index)
_dep_layer(name = this_name, base = base, dep = dep, binary = binary, testonly = kwargs.get("testonly"), visibility = visibility, tags = tags)
base = this_name
Expand Down