Use empty string as fallback value for undefined environment variables #2261
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation of dockerfile_build rule looks up for environment variables value and uses `None` as fallback value. This causes to resolve into `--build-arg <ENV_VAR>=None` build argument, which is seen as valid string. Instead, we should fallback to empty string for undefined environment variables, which resolves to `--build-arg <ENV_VAR>=''` and is interpreted as empty value.
k0walik
requested review from
gravypod,
linzhp,
pcj,
smukherj1 and
uhthomas
as code owners
|
This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. |
github-actions
bot
added
the
Can Close?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The current implementation of dockerfile_build rule looks up for environment variables value and uses
Noneas fallback value for undefined one. This causes to resolve into--build-arg <ENV_VAR>=Nonebuild argument, which is interpreted as valid, defined value.What is the new behavior?
Instead, we should fallback to empty string for undefined environment variables, which resolves to
--build-arg <ENV_VAR>=''and is interpreted as empty value. This would match the same output as produced in shell:Does this PR introduce a breaking change?
Other information