Skip to content

Commit 8ea7d0b

Browse files
committed
Update runner to use override_module when correct
1 parent bc77cd3 commit 8ea7d0b

File tree

2 files changed

+5
-17
lines changed

2 files changed

+5
-17
lines changed

examples/associates/WORKSPACE

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,6 @@ kt_register_toolchains()
1616

1717
load("@rules_kotlin//src/main/starlark/core/repositories:versions.bzl", "versions")
1818

19-
http_archive(
20-
name = "rules_android",
21-
sha256 = "cd06d15dd8bb59926e4d65f9003bfc20f9da4b2519985c27e190cddc8b7a7806",
22-
strip_prefix = "rules_android-0.1.1",
23-
urls = ["https://github.com/bazelbuild/rules_android/archive/v0.1.1.zip"],
24-
)
25-
2619
http_archive(
2720
name = "bazel_skylib",
2821
sha256 = versions.SKYLIB_SHA,
@@ -52,9 +45,3 @@ maven_install(
5245
"https://repo1.maven.org/maven2",
5346
],
5447
)
55-
56-
http_archive(
57-
name = "rules_pkg",
58-
sha256 = "8a298e832762eda1830597d64fe7db58178aa84cd5926d76d5b744d6558941c2",
59-
url = "https://github.com/bazelbuild/rules_pkg/releases/download/0.7.0/rules_pkg-0.7.0.tar.gz",
60-
)

src/main/kotlin/io/bazel/kotlin/test/BazelIntegrationTestRunner.kt

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ object BazelIntegrationTestRunner {
6060
bzlmod && workspace.hasModule() || !bzlmod && workspace.hasWorkspace()
6161
}.forEach { bzlmod ->
6262
println("Starting bzlmod $bzlmod test")
63+
val overrideFlag = if (bzlmod) "--override_module=rules_kotlin=$unpack" else "--override_repository=rules_kotlin=$unpack"
6364
bazel.run(
6465
workspace,
6566
"--bazelrc=$bazelrc",
@@ -77,13 +78,13 @@ object BazelIntegrationTestRunner {
7778
"--bazelrc=$bazelrc",
7879
"info",
7980
*version.workspaceFlag(bzlmod),
80-
"--override_repository=rules_kotlin=$unpack",
81+
overrideFlag
8182
).onFailThrow()
8283
bazel.run(
8384
workspace,
8485
"--bazelrc=$bazelrc",
8586
"build",
86-
"--override_repository=rules_kotlin=$unpack",
87+
overrideFlag,
8788
"//...",
8889
*version.workspaceFlag(bzlmod)
8990
).onFailThrow()
@@ -92,7 +93,7 @@ object BazelIntegrationTestRunner {
9293
"--bazelrc=$bazelrc",
9394
"query",
9495
*version.workspaceFlag(bzlmod),
95-
"--override_repository=rules_kotlin=$unpack",
96+
overrideFlag,
9697
"kind(\".*_test\", \"//...\")",
9798
).ok { process ->
9899
if (process.stdOut.isNotEmpty()) {
@@ -101,7 +102,7 @@ object BazelIntegrationTestRunner {
101102
"--bazelrc=$bazelrc",
102103
"test",
103104
*version.workspaceFlag(bzlmod),
104-
"--override_repository=rules_kotlin=$unpack",
105+
overrideFlag,
105106
"--test_output=all",
106107
"//...",
107108
).onFailThrow()

0 commit comments

Comments
 (0)