Skip to content

Commit e644ea7

Browse files
committed
Provision build tools API with http_archive over Maven
1 parent b6fa000 commit e644ea7

File tree

10 files changed

+25
-1216
lines changed

10 files changed

+25
-1216
lines changed

MODULE.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ use_repo(
2929
"com_github_jetbrains_kotlin",
3030
"com_github_jetbrains_kotlin_git",
3131
"com_github_pinterest_ktlint",
32+
"kotlin_build_tools_impl",
3233
"kotlinx_serialization_core_jvm",
3334
"kotlinx_serialization_json",
3435
"kotlinx_serialization_json_jvm",

MODULE.release.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ use_repo(
3030
"kotlinx_serialization_core_jvm",
3131
"kotlinx_serialization_json",
3232
"kotlinx_serialization_json_jvm",
33+
"kotlin_build_tools_impl",
3334
)
3435

3536
register_toolchains("//kotlin/internal:default_toolchain")

kotlin_rules_maven_install.json

Lines changed: 3 additions & 1210 deletions
Large diffs are not rendered by default.

src/main/kotlin/BUILD.release.bazel

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ java_binary(
4747
"//kotlin/compiler:symbol-processing-cmdline",
4848
"//src/main/kotlin/io/bazel/kotlin/compiler",
4949
"@com_github_jetbrains_kotlin//:home",
50+
"@kotlin_build_tools_impl//jar",
5051
"@kotlinx_serialization_core_jvm//jar",
5152
"@kotlinx_serialization_json//jar",
5253
"@kotlinx_serialization_json_jvm//jar",
@@ -55,10 +56,10 @@ java_binary(
5556
"-D@com_github_jetbrains_kotlinx...serialization-core-jvm=$(rlocationpath @kotlinx_serialization_core_jvm//jar)",
5657
"-D@com_github_jetbrains_kotlinx...serialization-json=$(rlocationpath @kotlinx_serialization_json//jar)",
5758
"-D@com_github_jetbrains_kotlinx...serialization-json-jvm=$(rlocationpath @kotlinx_serialization_json_jvm//jar)",
59+
"-D@com_github_jetbrains_kotlin...build-tools-impl=$(rlocationpath @kotlin_build_tools_impl//jar)",
5860
"-D@com_github_jetbrains_kotlin...jvm-abi-gen=$(rlocationpath //kotlin/compiler:jvm-abi-gen)",
5961
"-D@com_github_jetbrains_kotlin...kotlin-compiler=$(rlocationpath //kotlin/compiler:kotlin-compiler)",
6062
"-D@com_github_jetbrains_kotlin...kapt=$(rlocationpath //kotlin/compiler:kotlin-annotation-processing)",
61-
"-D@com_github_jetbrains_kotlin...build-tools-impl=$(rlocationpath @kotlin_rules_maven//:org_jetbrains_kotlin_kotlin_build_tools_impl)",
6263
"-D@rules_kotlin...jdeps-gen=$(rlocationpath //src/main/kotlin:jdeps-gen)",
6364
"-D@rules_kotlin...skip-code-gen=$(rlocationpath //src/main/kotlin:skip-code-gen)",
6465
"-D@rules_kotlin...compiler=$(rlocationpath //src/main/kotlin/io/bazel/kotlin/compiler)",

src/main/kotlin/io/bazel/kotlin/builder/cmd/BUILD.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ kt_bootstrap_binary(
2626
"//src/main/kotlin:skip-code-gen",
2727
"//src/main/kotlin/io/bazel/kotlin/compiler:compiler.jar",
2828
"@com_github_jetbrains_kotlin//:home",
29-
"@kotlin_rules_maven//:org_jetbrains_kotlin_kotlin_build_tools_impl",
29+
"@kotlin_build_tools_impl//jar",
3030
"@kotlinx_serialization_core_jvm//jar",
3131
"@kotlinx_serialization_json//jar",
3232
"@kotlinx_serialization_json_jvm//jar",
@@ -35,10 +35,10 @@ kt_bootstrap_binary(
3535
"-D@com_github_jetbrains_kotlinx...serialization-core-jvm=$(rlocationpath @kotlinx_serialization_core_jvm//jar)",
3636
"-D@com_github_jetbrains_kotlinx...serialization-json=$(rlocationpath @kotlinx_serialization_json//jar)",
3737
"-D@com_github_jetbrains_kotlinx...serialization-json-jvm=$(rlocationpath @kotlinx_serialization_json_jvm//jar)",
38+
"-D@com_github_jetbrains_kotlin...build-tools-impl=$(rlocationpath @kotlin_build_tools_impl//jar)",
3839
"-D@com_github_jetbrains_kotlin...jvm-abi-gen=$(rlocationpath //kotlin/compiler:jvm-abi-gen)",
3940
"-D@com_github_jetbrains_kotlin...kotlin-compiler=$(rlocationpath //kotlin/compiler:kotlin-compiler)",
4041
"-D@com_github_jetbrains_kotlin...kapt=$(rlocationpath //kotlin/compiler:kotlin-annotation-processing)",
41-
"-D@com_github_jetbrains_kotlin...build-tools-impl=$(rlocationpath @kotlin_rules_maven//:org_jetbrains_kotlin_kotlin_build_tools_impl)",
4242
"-D@rules_kotlin...jdeps-gen=$(rlocationpath //src/main/kotlin:jdeps-gen)",
4343
"-D@rules_kotlin...skip-code-gen=$(rlocationpath //src/main/kotlin:skip-code-gen)",
4444
"-D@rules_kotlin...compiler=$(rlocationpath //src/main/kotlin/io/bazel/kotlin/compiler:compiler.jar)",

src/main/starlark/core/repositories/initialize.release.bzl

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,13 @@ def kotlin_repositories(
9393
urls = [url.format(version = versions.KOTLINX_SERIALIZATION_JSON_JVM.version) for url in versions.KOTLINX_SERIALIZATION_JSON_JVM.url_templates],
9494
)
9595

96+
maybe(
97+
http_jar,
98+
name = "kotlin_build_tools_impl",
99+
sha256 = versions.KOTLIN_BUILD_TOOLS_IMPL.sha256,
100+
urls = [url.format(version = versions.KOTLIN_BUILD_TOOLS_IMPL.version) for url in versions.KOTLIN_BUILD_TOOLS_IMPL.url_templates],
101+
)
102+
96103
if is_bzlmod:
97104
return
98105

src/main/starlark/core/repositories/versions.bzl

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,13 @@ versions = struct(
8787
],
8888
sha256 = "9f74659d447d3df29cabe0c8ee068810af313a584c1bbdde821f9894127f26e0",
8989
),
90+
KOTLIN_BUILD_TOOLS_IMPL = version(
91+
version = "2.1.20",
92+
url_templates = [
93+
"https://repo1.maven.org/maven2/org/jetbrains/kotlin/kotlin-build-tools-impl/{version}/kotlin-build-tools-impl-{version}.jar",
94+
],
95+
sha256 = "6e94896e321603e3bfe89fef02478e44d1d64a3d25d49d0694892ffc01c60acf",
96+
),
9097
RULES_ANDROID = version(
9198
version = "0.6.4",
9299
url_templates = [

src/test/kotlin/io/bazel/kotlin/builder/BUILD

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ java_library(
4747
"//kotlin/compiler:kotlin-reflect",
4848
"//kotlin/compiler:kotlin-stdlib",
4949
"@bazel_tools//tools/jdk:JacocoCoverage",
50-
"@kotlin_rules_maven//:org_jetbrains_kotlin_kotlin_build_tools_api",
5150
],
5251
deps = _COMMON_DEPS + [
5352
"//src/main/kotlin/io/bazel/kotlin/builder/tasks",

src/test/kotlin/io/bazel/kotlin/builder/KotlinAbstractTestBuilder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ static KotlinToolchain toolchainForTest() {
235235
return KotlinToolchain.createToolchain(
236236
javaHome,
237237
new File(Deps.Dep.fromLabel("//kotlin/compiler:kotlin-compiler").singleCompileJar()),
238-
new File(Deps.Dep.fromLabel("@kotlin_rules_maven//:org_jetbrains_kotlin_kotlin_build_tools_impl").singleCompileJar()),
238+
new File(Deps.Dep.fromLabel("@kotlin_build_tools_impl//jar").singleCompileJar()),
239239
new File(Deps.Dep.fromLabel("//src/main/kotlin/io/bazel/kotlin/compiler:compiler.jar").singleCompileJar()),
240240
new File(Deps.Dep.fromLabel("//kotlin/compiler:jvm-abi-gen").singleCompileJar()),
241241
new File(Deps.Dep.fromLabel("//src/main/kotlin:skip-code-gen").singleCompileJar()),

src/test/kotlin/io/bazel/kotlin/defs.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ def kt_rules_test(name, **kwargs):
4747
"@kotlinx_serialization_core_jvm//jar",
4848
"@kotlinx_serialization_json//jar",
4949
"@kotlinx_serialization_json_jvm//jar",
50-
"@kotlin_rules_maven//:org_jetbrains_kotlin_kotlin_build_tools_impl",
50+
"@kotlin_build_tools_impl//jar",
5151
] + args["data"]:
5252
if dep not in args["data"]:
5353
args["data"].append(dep)

0 commit comments

Comments
 (0)