Skip to content

Commit ffff1cf

Browse files
authored
Include more tests in the root test suite (#1050)
1 parent fac4a15 commit ffff1cf

File tree

7 files changed

+76
-22
lines changed

7 files changed

+76
-22
lines changed

BUILD

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,11 @@ ktlint_config(
3636
test_suite(
3737
name = "all_tests",
3838
tests = [
39+
"//docs:are_docs_up_to_date_test",
3940
"//src/test/kotlin/io/bazel/kotlin:assertion_tests",
4041
"//src/test/kotlin/io/bazel/kotlin/builder:builder_tests",
42+
"//src/test/kotlin/io/bazel/kotlin/integration:integration_tests",
43+
"//src/test/kotlin/io/bazel/worker:worker_tests",
4144
"//src/test/starlark:convert_tests",
4245
],
4346
)
@@ -48,6 +51,8 @@ test_suite(
4851
tests = [
4952
":all_tests",
5053
"//src/test/kotlin/io/bazel/kotlin:local_assertion_tests",
54+
"//src/test/kotlin/io/bazel/kotlin/integration:local_integration_tests",
55+
"//src/test/kotlin/io/bazel/worker:local_worker_tests",
5156
"//src/test/starlark:convert_tests",
5257
],
5358
)

src/test/kotlin/io/bazel/kotlin/builder/BUILD

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,8 @@ java_library(
6060
test_suite(
6161
name = "builder_tests",
6262
tests = [
63-
"//src/test/kotlin/io/bazel/kotlin/builder/tasks",
64-
"//src/test/kotlin/io/bazel/kotlin/builder/utils",
63+
"//src/test/kotlin/io/bazel/kotlin/builder/tasks:tasks_tests",
64+
"//src/test/kotlin/io/bazel/kotlin/builder/utils:utils_tests",
6565
],
6666
visibility = ["//visibility:public"],
6767
)

src/test/kotlin/io/bazel/kotlin/builder/tasks/BUILD.bazel

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,5 +98,16 @@ kt_rules_test(
9898
)
9999

100100
test_suite(
101-
name = "tasks",
101+
name = "tasks_tests",
102+
tests = [
103+
":JdepsMergerTest",
104+
":JdepsParserTest",
105+
":KotlinBuilderJsTest",
106+
":KotlinBuilderJvmAbiTest",
107+
":KotlinBuilderJvmBasicTest",
108+
":KotlinBuilderJvmCoverageTest",
109+
":KotlinBuilderJvmJdepsTest",
110+
":KotlinBuilderJvmKaptTest",
111+
":KotlinBuilderJvmStrictDepsTest",
112+
],
102113
)

src/test/kotlin/io/bazel/kotlin/builder/utils/BUILD.bazel

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,5 +48,10 @@ kt_jvm_test(
4848
)
4949

5050
test_suite(
51-
name = "utils",
51+
name = "utils_tests",
52+
tests = [
53+
":ArgMapTest",
54+
":JarCreatorTest",
55+
":SourceJarCreatorTest",
56+
],
5257
)

src/test/kotlin/io/bazel/kotlin/integration/BUILD.bazel

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,3 +35,18 @@ kt_jvm_test(
3535
"@kotlin_rules_maven//:junit_junit",
3636
],
3737
)
38+
39+
test_suite(
40+
name = "integration_tests",
41+
tests = [
42+
":WriteWorkspaceTest",
43+
],
44+
)
45+
46+
test_suite(
47+
name = "local_integration_tests",
48+
tests = [
49+
":MixedSourceCompileTest",
50+
":integration_tests",
51+
],
52+
)

src/test/kotlin/io/bazel/worker/BUILD.bazel

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,3 +71,21 @@ kt_jvm_test(
7171
"@kotlin_rules_maven//:com_google_truth_truth",
7272
],
7373
)
74+
75+
test_suite(
76+
name = "worker_tests",
77+
tests = [
78+
":IOTest",
79+
":InvocationWorkerTest",
80+
":JavaPersistentWorkerTest",
81+
":WorkerContextTest",
82+
":WorkerEnvironmentTest",
83+
],
84+
)
85+
86+
test_suite(
87+
name = "local_worker_tests",
88+
tests = [
89+
":worker_tests",
90+
],
91+
)

src/test/kotlin/io/bazel/worker/WorkerEnvironmentTest.kt

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -25,52 +25,52 @@ import org.junit.Test
2525
class WorkerEnvironmentTest {
2626

2727
@Test
28-
fun send() {
29-
val give = (1..5).map { WorkRequest.newBuilder().setRequestId(it).addArguments("foo").build() }
28+
fun sendOne() {
29+
val give = WorkRequest.newBuilder().setRequestId(1).addArguments("foo").build()
3030
val got = WorkerEnvironment.inProcess {
3131
task { stdIn, stdOut ->
3232
generateSequence {
33-
WorkRequest.parseDelimitedFrom(stdIn)
33+
WorkRequest.parseDelimitedFrom(stdIn).also { println("got $it") }
3434
}.forEach { req ->
3535
WorkerProtocol.WorkResponse.newBuilder().setRequestId(req.requestId).build()
36+
.also { println("sent $it") }
3637
.writeDelimitedTo(stdOut)
3738
}
3839
}
3940

40-
give.forEach { writeStdIn(it) }
41+
writeStdIn(give)
4142
closeStdIn()
4243

43-
return@inProcess generateSequence { readStdOut() }.toSet()
44+
return@inProcess readStdOut()
4445
}
4546

46-
assertThat(got).containsExactlyElementsIn(
47-
(1..5).map { id ->
48-
WorkerProtocol.WorkResponse.newBuilder().setRequestId(id).build()
49-
}
50-
)
47+
assertThat(got)
48+
.isEqualTo(WorkerProtocol.WorkResponse.newBuilder().setRequestId(1).build())
5149
}
5250

5351
@Test
54-
fun sendOne() {
55-
val give = WorkRequest.newBuilder().setRequestId(1).addArguments("foo").build()
52+
fun send() {
53+
val give = (1..5).map { WorkRequest.newBuilder().setRequestId(it).addArguments("foo").build() }
5654
val got = WorkerEnvironment.inProcess {
5755
task { stdIn, stdOut ->
5856
generateSequence {
59-
WorkRequest.parseDelimitedFrom(stdIn).also { println("got $it") }
57+
WorkRequest.parseDelimitedFrom(stdIn)
6058
}.forEach { req ->
6159
WorkerProtocol.WorkResponse.newBuilder().setRequestId(req.requestId).build()
62-
.also { println("sent $it") }
6360
.writeDelimitedTo(stdOut)
6461
}
6562
}
6663

67-
writeStdIn(give)
64+
give.forEach { writeStdIn(it) }
6865
closeStdIn()
6966

70-
return@inProcess readStdOut()
67+
return@inProcess generateSequence { readStdOut() }.toSet()
7168
}
7269

73-
assertThat(got)
74-
.isEqualTo(WorkerProtocol.WorkResponse.newBuilder().setRequestId(1).build())
70+
assertThat(got).containsExactlyElementsIn(
71+
(1..5).map { id ->
72+
WorkerProtocol.WorkResponse.newBuilder().setRequestId(id).build()
73+
}
74+
)
7575
}
7676
}

0 commit comments

Comments
 (0)