Relativize jar paths in jdeps and rework BazelRunFiles to return relative paths
#1120
+107
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunkumar9t2
requested review from
ahumesky,
cgruber,
restingbull,
Bencodes and
nkoroste
as code owners
|
Seems RBE is failing, will revisit. |
|
@arunkumar9t2 PR looks good to me as long as you can take care of the RBE case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #941
We found that certain Kotlin versions, 1.8.10 for example can produce absolute paths in jdeps output. Although this is fixed in 1.8.20 (not sure which commit caused this on Kotlin side), this PR ensures jdeps jars always use relative path.