ci: Check pre-commit hooks in CI (#922)

* ci: Check pre-commit hooks in CI

* fix buildifier warnings

* fix buildifier warnings

* fix exclude

Author: hofbi

.github/workflows/pre-commit.yml

@@ -0,0 +1,14 @@
+name: Pre-Commit
+
+on:
+  push:
+    branches: [main]
+  pull_request:
+    branches: [main]
+
+jobs:
+  pre-commit:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: pre-commit/[email protected]

.pre-commit-config.yaml

@@ -29,5 +29,5 @@ repos:
           exclude: |
             (?x)^(
               CHANGELOG.md|
-              tests/testdata/|
+              tests/testdata/
             )

mappings.bzl

@@ -12,6 +12,8 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+"""File mappings for packaging rules."""
+
 load(
     "//pkg:mappings.bzl",
     _REMOVE_BASE_DIRECTORY = "REMOVE_BASE_DIRECTORY",

pkg.bzl

@@ -12,6 +12,8 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+"""Rules for manipulation of various packaging."""
+
 load("//pkg:deb.bzl", _pkg_deb = "pkg_deb")
 load("//pkg:tar.bzl", _pkg_tar = "pkg_tar")
 load("//pkg:zip.bzl", _pkg_zip = "pkg_zip")

pkg/pkg.bzl

@@ -11,6 +11,7 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
+
 """Rules for manipulation of various packaging."""
 
 load("//pkg/private/deb:deb.bzl", _pkg_deb = "pkg_deb")

pkg/private/pkg_files.bzl

@@ -394,6 +394,7 @@ def add_from_default_info(
       data_path: path to package
       data_path_without_prefix: path to the package after prefix stripping
       include_runfiles: Include runfiles
+      workspace_name: name of the main workspace
     """
     if not DefaultInfo in src:
         return

pkg/rpm.bzl

@@ -49,6 +49,7 @@ def pkg_rpm(name, srcs = None, spec_file = None, subrpms = None, **kwargs):
       name: rule name
       srcs: pkg_rpm_pfg `srcs` attribute
       spec_file: pkg_rpm_legacy `spec_file` attribute
+      subrpms: pkg_rpm_pfg `subrpms` attribute
       **kwargs: arguments to either `pkg_rpm_pfg` or `pkg_rpm_legacy`,
                 depending on mode
 

tests/mappings/mappings_test.bzl

@@ -60,7 +60,6 @@ def _pkg_files_contents_test_impl(ctx):
 
     expected_dests = {e: None for e in ctx.attr.expected_dests}
     actual_dests = target_under_test[PackageFilesInfo].dest_src_map.keys()
-    n_found = 0
 
     for actual in actual_dests:
         asserts.true(