Skip to content

Commit 0184f9f

Browse files
authored
Remove repeated _is_proc_macro calls in collect_deps (#3633)
This shows up in analysis time profiles. Before: <img width="1679" height="80" alt="image" src="https://github.com/user-attachments/assets/aa0f225e-fb67-4765-b76f-2e9c512d0e84" /> After: <img width="1680" height="84" alt="image" src="https://github.com/user-attachments/assets/af949612-e412-4015-b660-d097971723b7" />
1 parent 31453f9 commit 0184f9f

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

rust/private/rustc.bzl

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -292,14 +292,15 @@ def collect_deps(
292292
dep = crate_info,
293293
))
294294

295+
is_proc_macro = _is_proc_macro(crate_info)
295296
transitive_crates.append(
296297
depset(
297298
[crate_info],
298-
transitive = [] if _is_proc_macro(crate_info) else [dep_info.transitive_crates],
299+
transitive = [] if is_proc_macro else [dep_info.transitive_crates],
299300
),
300301
)
301302

302-
if _is_proc_macro(crate_info):
303+
if is_proc_macro:
303304
# This crate's data and its non-macro dependencies' data are proc macro data.
304305
transitive_proc_macro_data.append(crate_info.data)
305306
transitive_proc_macro_data.append(dep_info.transitive_data)
@@ -324,18 +325,18 @@ def collect_deps(
324325
transitive_metadata_outputs.append(
325326
depset(
326327
[depend_on],
327-
transitive = [] if _is_proc_macro(crate_info) else [dep_info.transitive_metadata_outputs],
328+
transitive = [] if is_proc_macro else [dep_info.transitive_metadata_outputs],
328329
),
329330
)
330331

331332
transitive_crate_outputs.append(
332333
depset(
333334
[crate_info.output],
334-
transitive = [] if _is_proc_macro(crate_info) else [dep_info.transitive_crate_outputs],
335+
transitive = [] if is_proc_macro else [dep_info.transitive_crate_outputs],
335336
),
336337
)
337338

338-
if "proc-macro" not in [crate_info.type, crate_info.wrapped_crate_type]:
339+
if not is_proc_macro:
339340
transitive_noncrates.append(dep_info.transitive_noncrates)
340341
transitive_link_search_paths.append(dep_info.link_search_path_files)
341342

0 commit comments

Comments
 (0)