Skip to content

Commit ec35284

Browse files
authored
Flip default for incompatible_change_clippy_error_format to true. (#3574)
In accordance with the process described [here](https://github.com/bazelbuild/rules_rust/blob/main/COMPATIBILITY.md#compatibility-before-10), I will let at least another two weeks pass before removing the setting entirely.
1 parent a7280db commit ec35284

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

rust/repositories.bzl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -398,15 +398,15 @@ _RUST_TOOLCHAIN_REPOSITORY_ATTRS = {
398398
"opt_level": attr.string_dict(
399399
doc = "Rustc optimization levels. For more details see the documentation for `rust_toolchain.opt_level`.",
400400
),
401-
"strip_level": attr.string_dict(
402-
doc = "Rustc strip levels. For more details see the documentation for `rust_toolchain.strip_level`.",
403-
),
404401
"rustfmt_version": attr.string(
405402
doc = "The version of the tool among \"nightly\", \"beta\", or an exact version.",
406403
),
407404
"sha256s": attr.string_dict(
408405
doc = "A dict associating tool subdirectories to sha256 hashes. See [rust_register_toolchains](#rust_register_toolchains) for more details.",
409406
),
407+
"strip_level": attr.string_dict(
408+
doc = "Rustc strip levels. For more details see the documentation for `rust_toolchain.strip_level`.",
409+
),
410410
"target_triple": attr.string(
411411
doc = "The Rust-style target that this compiler builds for.",
412412
mandatory = True,

rust/settings/settings.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -321,7 +321,7 @@ def incompatible_change_clippy_error_format():
321321
"""
322322
incompatible_flag(
323323
name = "incompatible_change_clippy_error_format",
324-
build_setting_default = False,
324+
build_setting_default = True,
325325
issue = "https://github.com/bazelbuild/rules_rust/issues/3494",
326326
)
327327

0 commit comments

Comments
 (0)