Skip to content

Commit 4025bcd

Browse files
committed
Fix buildifier lint warnings
1 parent c0631c8 commit 4025bcd

File tree

9 files changed

+12
-9
lines changed

9 files changed

+12
-9
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111
([#52](https://github.com/bazelbuild/rules_testing/issues/52))
1212
* StructSubject for asserting arbitrary structs.
1313
([#53](https://github.com/bazelbuild/rules_testing/issues/53))
14+
* CollectionSubject now supports tuples.
15+
([#69](https://github.com/bazelbuild/rules_testing/pull/69))
1416
* (docs) Created human-friendly changelog
1517

1618
## [0.3.0] - 2023-07-06

docgen/docgen.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414

1515
"""Rules to help generate rules_testing docs."""
1616

17-
load("@io_bazel_stardoc//stardoc:stardoc.bzl", "stardoc")
1817
load("@bazel_skylib//rules:build_test.bzl", "build_test")
18+
load("@io_bazel_stardoc//stardoc:stardoc.bzl", "stardoc")
1919

2020
def sphinx_stardocs(name, bzl_libraries, **kwargs):
2121
"""Generate Sphinx-friendly markdown docs using Stardoc for bzl libraries.

lib/private/default_info_subject.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@
1414

1515
"""# DefaultInfoSubject"""
1616

17-
load(":runfiles_subject.bzl", "RunfilesSubject")
1817
load(":depset_file_subject.bzl", "DepsetFileSubject")
1918
load(":file_subject.bzl", "FileSubject")
19+
load(":runfiles_subject.bzl", "RunfilesSubject")
2020

2121
def _default_info_subject_new(info, *, meta):
2222
"""Creates a `DefaultInfoSubject`

lib/test_suite.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
Aggregates multiple Starlark tests in a single test_suite.
44
"""
55

6-
load("//lib/private:util.bzl", "get_test_name_from_function")
76
load("//lib:unit_test.bzl", "unit_test")
7+
load("//lib/private:util.bzl", "get_test_name_from_function")
88

99
def test_suite(name, *, tests = [], basic_tests = [], test_kwargs = {}):
1010
"""Instantiates given test macros/implementations and gathers their main targets into a `test_suite`.

lib/truth.bzl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,11 +51,11 @@ load("//lib/private:expect.bzl", "Expect")
5151
load("//lib/private:file_subject.bzl", "FileSubject")
5252
load("//lib/private:int_subject.bzl", "IntSubject")
5353
load("//lib/private:label_subject.bzl", "LabelSubject")
54+
load("//lib/private:matching.bzl", _matching = "matching")
5455
load("//lib/private:runfiles_subject.bzl", "RunfilesSubject")
5556
load("//lib/private:str_subject.bzl", "StrSubject")
56-
load("//lib/private:target_subject.bzl", "TargetSubject")
57-
load("//lib/private:matching.bzl", _matching = "matching")
5857
load("//lib/private:struct_subject.bzl", "StructSubject")
58+
load("//lib/private:target_subject.bzl", "TargetSubject")
5959

6060
# Rather than load many symbols, just load this symbol, and then all the
6161
# asserts will be available.

tests/struct_subject/struct_subject_tests.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414

1515
"""Tests for StructSubject"""
1616

17-
load("//lib:truth.bzl", "subjects")
1817
load("//lib:test_suite.bzl", "test_suite")
18+
load("//lib:truth.bzl", "subjects")
1919
load("//tests:test_util.bzl", "test_util")
2020

2121
_tests = []

tests/test_util.bzl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,10 @@
1414

1515
"""Utilities for testing rules_testing code."""
1616

17+
load("//lib:truth.bzl", "matching")
18+
1719
# buildifier: disable=bzl-visibility
1820
load("//lib/private:expect_meta.bzl", "ExpectMeta")
19-
load("//lib:truth.bzl", "matching")
2021

2122
def _fake_meta(real_env):
2223
"""Create a fake ExpectMeta object for testing.

tests/truth_tests.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
"""Tests for truth.bzl."""
1616

1717
load("@bazel_skylib//lib:unittest.bzl", ut_asserts = "asserts")
18-
load("//lib:truth.bzl", "matching", "subjects", "truth")
1918
load("//lib:analysis_test.bzl", "analysis_test", "test_suite")
19+
load("//lib:truth.bzl", "matching", "subjects", "truth")
2020

2121
# Bazel 5 has a bug where every access of testing.ExecutionInfo is a new
2222
# object that isn't equal to itself. This is fixed in Bazel 6.

tests/unit_test_tests.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
"""Tests for unit_test."""
22

3-
load("//lib:unit_test.bzl", "unit_test")
43
load("//lib:test_suite.bzl", "test_suite")
4+
load("//lib:unit_test.bzl", "unit_test")
55

66
def _test_basic(env):
77
_ = env # @unused

0 commit comments

Comments
 (0)