Remove collect_actions_recursively

It wasn't implemented correctly / the implementation was never finished.

PiperOrigin-RevId: 737548039

Author: A Googler

CHANGELOG.md

@@ -5,6 +5,7 @@
 [0.X.0]: https://github.com/bazelbuild/rules_testing/releases/tag/v0.X.0
 
 ## Changed
+
 * Add `{bindir}` to formatting variables.
 * Format values in `ActionsSubject.contains_flag_values()`.
 * `CollectionSubject` accepts new constructor parameter `format`. When used
@@ -13,13 +14,21 @@
   `action.argv().contains_at_least(["-f", "{bindir}/{package}/input.txt"])`.
 
 ### Added
+
 * Nothing yet
 
+### Removed
+
+* Removed `util.recursive_testing_aspect` and
+  `analysis_test.collect_actions_recursively`. They were never properly
+  implemented.
+
 ## [0.7.0] - 2024-10-29
 
 [0.7.0]: https://github.com/bazelbuild/rules_testing/releases/tag/v0.7.0
 
 ### Added
+
 * `matching.any()` and `matching.all()` for composing `Matcher` objects using
   "or" and "and" semantics, respectively
 * Predicate-variants for RunfilesSubject methods:

lib/private/analysis_test.bzl

@@ -20,7 +20,7 @@ Support for testing analysis phase logic, such as rules.
 load("@bazel_skylib//lib:dicts.bzl", "dicts")
 load("@bazel_skylib//lib:types.bzl", "types")
 load("//lib:truth.bzl", "truth")
-load("//lib:util.bzl", "recursive_testing_aspect", "testing_aspect")
+load("//lib:util.bzl", "testing_aspect")
 load("//lib/private:target_subject.bzl", "PROVIDER_SUBJECT_FACTORIES")
 load("//lib/private:util.bzl", "get_test_name_from_function")
 
@@ -140,7 +140,6 @@ def analysis_test(
         fragments = [],
         config_settings = {},
         extra_target_under_test_aspects = [],
-        collect_actions_recursively = False,
         provider_subject_factories = []):
     """Creates an analysis test from its implementation function.
 
@@ -216,8 +215,6 @@ def analysis_test(
           in your repository's context, not rule_testing's.
       extra_target_under_test_aspects: An optional list of aspects to apply to the target_under_test
           in addition to those set up by default for the test harness itself.
-      collect_actions_recursively: If true, runs testing_aspect over all attributes, otherwise
-          it is only applied to the target under test.
       provider_subject_factories: Optional list of ProviderSubjectFactory structs,
           these are additional provider factories on top of built in ones.
           A ProviderSubjectFactory is a struct with the following fields:
@@ -264,10 +261,7 @@ def analysis_test(
         target_under_test_cfg = None
 
     applied_aspects = []
-    if collect_actions_recursively:
-        applied_aspects.append(recursive_testing_aspect)
-    else:
-        applied_aspects.append(testing_aspect)
+    applied_aspects.append(testing_aspect)
     applied_aspects.extend(extra_target_under_test_aspects)
 
     target_under_test_attr_names = []

lib/util.bzl

@@ -177,16 +177,6 @@ testing_aspect = aspect(
     implementation = _testing_aspect_impl,
 )
 
-# The same as `testing_aspect`, but recurses through all attributes in the
-# whole graph. This is useful if you need to extract information about
-# targets that aren't direct dependencies of the target under test, or to
-# reconstruct a more complete graph of inputs/outputs/generating-target.
-# TODO(ilist): make private, after switching python tests to new testing framework
-recursive_testing_aspect = aspect(
-    implementation = _testing_aspect_impl,
-    attr_aspects = ["*"],
-)
-
 def get_target_attrs(env):
     return analysistest.target_under_test(env)[TestingAspectInfo].attrs
 
@@ -264,7 +254,6 @@ util = struct(
     force_exec_config = force_exec_config,
     helper_target = helper_target,
     merge_kwargs = merge_kwargs,
-    recursive_testing_aspect = recursive_testing_aspect,
     runfiles_map = runfiles_map,
     runfiles_paths = runfiles_paths,
     short_paths = short_paths,