better failure report

graham jenson · graham jenson · commit 2b0190507f8a · 2019-12-13T14:14:05.000-08:00
diff --git a/ruby/private/sdk.bzl b/ruby/private/sdk.bzl
@@ -4,7 +4,7 @@ load(
 )
 
 def ruby_register_toolchains(version = "host"):
-    """Registersr ruby toolchains in the WORKSPACE file."""
+    """Registers ruby toolchains in the WORKSPACE file."""
 
     supported_versions = ["host", "2.6.3", "2.6.5"]
     if version in supported_versions:
@@ -13,7 +13,7 @@ def ruby_register_toolchains(version = "host"):
             version = version,
         )
     else:
-        fail("unsupported ruby version in `ruby_register_toolchains`")
+        fail("ruby_register_toolchains: unsupported ruby version '%s' not in '%s'" % (version, supported_versions))
 
     native.register_toolchains(
         "@org_ruby_lang_ruby_toolchain//:toolchain",

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@ load(`
`4`	`4`	`)`
`5`	`5`
`6`	`6`	`def ruby_register_toolchains(version = "host"):`
`7`		`- """Registersr ruby toolchains in the WORKSPACE file."""`
	`7`	`+ """Registers ruby toolchains in the WORKSPACE file."""`
`8`	`8`
`9`	`9`	`supported_versions = ["host", "2.6.3", "2.6.5"]`
`10`	`10`	`if version in supported_versions:`
`@@ -13,7 +13,7 @@ def ruby_register_toolchains(version = "host"):`
`13`	`13`	`version = version,`
`14`	`14`	`)`
`15`	`15`	`else:`
`16`		- fail("unsupported ruby version in `ruby_register_toolchains`")
	`16`	`+ fail("ruby_register_toolchains: unsupported ruby version '%s' not in '%s'" % (version, supported_versions))`
`17`	`17`
`18`	`18`	`native.register_toolchains(`
`19`	`19`	`"@org_ruby_lang_ruby_toolchain//:toolchain",`