arguments validation

Author: bazilio91

models/AsyncExecuteTask.php

@@ -38,11 +38,32 @@ public function validateMethod($attribute, $params)
         }
     }
 
-    public function validateArguments($attribute, $params) {
+    public function validateArguments($attribute, $params)
+    {
         if (!isset(array_flip(get_class_methods($this->class))[$this->method])) {
             $this->addError(
                 $attribute,
-                "Method {$this->method} of class {$this->class} does not exist"
+                "Can't validate attributes for not existing method {$this->method} of class {$this->class}"
+            );
+            return;
+        }
+
+        $refFunc = new \ReflectionMethod($this->class, $this->method);
+        $userArguments = array_keys($this->{$attribute});
+        $missingArguments = [];
+        foreach ($refFunc->getParameters() as $param) {
+            if (!$param->isOptional() && !in_array($param->getName(), $userArguments)) {
+                $missingArguments[] = $param->getName();
+            }
+        }
+
+        if (sizeof($missingArguments)) {
+            $this->addError(
+                $attribute,
+                "Method `{$this->method}` missing required arguments: " . implode(
+                    ', ',
+                    $missingArguments
+                )
             );
         }
     }

tests/unit.suite.yml

@@ -3,4 +3,4 @@
 # suite for unit (internal) tests.
 class_name: UnitTester
 modules:
-    enabled: [Asserts, UnitHelper, Mockery]
+    enabled: [Asserts, UnitHelper]

tests/unit/AmqpTest.php

@@ -19,7 +19,7 @@ class TestException extends \Exception
 
 class BlackHole
 {
-    public function run($param)
+    public static function run($param)
     {
         throw new TestException($param);
     }
@@ -94,4 +94,31 @@ public function testAsyncExecuteTask()
 
         $this->fail('BlackHole method wasn\'t called.');
     }
+
+    public function testArgumentsValidation()
+    {
+        $aTask = new AsyncExecuteTask();
+        $aTask->setAttributes(
+            [
+                'class' => '\BlackHole',
+                'method' => 'run',
+                'arguments' => ['fail' => 'through the space']
+            ]
+        );
+
+        $this->assertFalse($aTask->validate());
+
+        $this->assertEquals(
+            $aTask->errors['arguments'][0],
+            "Method `run` missing required arguments: param"
+        );
+
+        try {
+            $this->async->sendTask($aTask);
+        } catch (bazilio\async\Exception $e) {
+            return;
+        }
+
+        $this->fail('Async doesn\'t reject invalid task.');
+    }
 }

tests/unit/UnitTester.php

@@ -1,4 +1,4 @@
-<?php //[STAMP] 7090f4f20ecbb9880d52b8a3056e9b0b
+<?php //[STAMP] 6cd8435c53a77903754e35ca70c87c63
 
 // This class was automatically generated by build task
 // You should not change it manually as it will be overwritten on next build
@@ -7,7 +7,6 @@
 
 use Codeception\Module\Asserts;
 use Codeception\Module\UnitHelper;
-use Codeception\Module\Mockery;
 
 /**
  * Inherited Methods